From: Adrian Bunk <bunk@stusta.de>
To: minyard@mvista.com
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/char/ipmi/ipmi_msghandler.c: make proc_ipmi_root static
Date: Thu, 13 Apr 2006 10:02:49 +0200 [thread overview]
Message-ID: <20060413080249.GH6517@stusta.de> (raw)
This patch makes the needlessly global struct proc_ipmi_root static.
Besides this, it removes an unused #ifdef CONFIG_PROC_FS from
include/linux/ipmi.h.
---
BTW: Please add an entry for IPMI to MAINTAINERS.
drivers/char/ipmi/ipmi_msghandler.c | 3 +--
include/linux/ipmi.h | 4 ----
2 files changed, 1 insertion(+), 6 deletions(-)
--- linux-2.6.17-rc1-mm2-full/include/linux/ipmi.h.old 2006-04-12 22:32:08.000000000 +0200
+++ linux-2.6.17-rc1-mm2-full/include/linux/ipmi.h 2006-04-12 22:32:20.000000000 +0200
@@ -210,11 +210,7 @@
*/
#include <linux/list.h>
#include <linux/module.h>
-
-#ifdef CONFIG_PROC_FS
#include <linux/proc_fs.h>
-extern struct proc_dir_entry *proc_ipmi_root;
-#endif /* CONFIG_PROC_FS */
/* Opaque type for a IPMI message user. One of these is needed to
send and receive messages. */
--- linux-2.6.17-rc1-mm2-full/drivers/char/ipmi/ipmi_msghandler.c.old 2006-04-12 22:32:29.000000000 +0200
+++ linux-2.6.17-rc1-mm2-full/drivers/char/ipmi/ipmi_msghandler.c 2006-04-12 22:32:45.000000000 +0200
@@ -57,8 +57,7 @@
static int initialized = 0;
#ifdef CONFIG_PROC_FS
-struct proc_dir_entry *proc_ipmi_root = NULL;
-EXPORT_SYMBOL(proc_ipmi_root);
+static struct proc_dir_entry *proc_ipmi_root = NULL;
#endif /* CONFIG_PROC_FS */
#define MAX_EVENTS_IN_QUEUE 25
next reply other threads:[~2006-04-13 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-13 8:02 Adrian Bunk [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-04-18 15:06 [2.6 patch] drivers/char/ipmi/ipmi_msghandler.c: make proc_ipmi_root static Adrian Bunk
2006-04-18 15:14 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060413080249.GH6517@stusta.de \
--to=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox