From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Ingo Oeser <ioe-lkml@rameria.de>
Cc: Rene Herman <rene.herman@keyaccess.nl>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.de>,
Greg KH <gregkh@suse.de>
Subject: Re: [ALSA STABLE 3/3] a few more -- unregister platform device again if probe was unsuccessful
Date: Thu, 13 Apr 2006 10:31:46 +0100 [thread overview]
Message-ID: <20060413093146.GB21632@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200604131126.35841.ioe-lkml@rameria.de>
On Thu, Apr 13, 2006 at 11:26:34AM +0200, Ingo Oeser wrote:
> Hi Rene,
> Wouldn't it be more useful to do these checks in
> platform_register_simple() and return the proper error value there?
Firstly, platform_device_register_simple() is going away.
Secondly, it's inappropriate to force this weirdo ALSA specific behaviour
on the rest of the platform device users.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2006-04-13 9:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-13 1:46 [ALSA STABLE 3/3] a few more -- unregister platform device again if probe was unsuccessful Rene Herman
2006-04-13 9:26 ` Ingo Oeser
2006-04-13 9:31 ` Russell King [this message]
2006-04-13 14:05 ` Rene Herman
2006-04-13 14:57 ` Russell King
2006-04-13 16:17 ` Rene Herman
2006-04-13 17:05 ` Russell King
2006-04-13 18:47 ` Rene Herman
2006-04-13 22:02 ` Greg KH
2006-04-13 23:12 ` Rene Herman
2006-04-15 13:16 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060413093146.GB21632@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=gregkh@suse.de \
--cc=ioe-lkml@rameria.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rene.herman@keyaccess.nl \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox