From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964775AbWDMSZM (ORCPT ); Thu, 13 Apr 2006 14:25:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964784AbWDMSZM (ORCPT ); Thu, 13 Apr 2006 14:25:12 -0400 Received: from mx1.suse.de ([195.135.220.2]:12194 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S964775AbWDMSZL (ORCPT ); Thu, 13 Apr 2006 14:25:11 -0400 Date: Thu, 13 Apr 2006 11:24:01 -0700 From: Greg KH To: tyler@agat.net Cc: rusty@rustcorp.com.au, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Kmod optimization Message-ID: <20060413182401.GA26885@suse.de> References: <20060413180345.GA10910@Starbuck> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060413180345.GA10910@Starbuck> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 13, 2006 at 08:03:45PM +0200, tyler@agat.net wrote: > Hi, > > the request_mod functions try to load automatically a module by running > a user mode process helper (modprobe). > > The user process is launched even if the module is already loaded. I > think it would be better to test if the module is already loaded. Does this cause a problem somehow? request_mod is called _very_ infrequently from a normal kernel these days, so I really don't think this is necessary. thanks, greg k-h