public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Kylene Jo Hall <kjhall@us.ibm.com>
Cc: kbuild-devel@lists.sourceforge.net, dustin.kirkland@us.ibm.com,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] make: add modules_update target
Date: Fri, 14 Apr 2006 13:02:22 -0400	[thread overview]
Message-ID: <20060414170222.GA19172@thunk.org> (raw)
In-Reply-To: <1145027216.12054.164.camel@localhost.localdomain>

On Fri, Apr 14, 2006 at 10:06:56AM -0500, Kylene Jo Hall wrote:
> Here is a a patch that adds a kernel build target called
> "modules_update".  
> 
> The existing "modules_install" target blows away the entire 
> /lib/modules/`uname -r`/kernel directory and copies out every single
> module when called at the top level.
> 
> This new "modules_update" target only copies out modules that have
> changed, using "cp -u".  This less zealous method is a more efficient
> approach to module installation for kernel developers working on single,
> or small numbers of modules.  

Hi Kylene,

This works as long as the .config hasn't been changed so that some
configuration options haven't been changed so that a driver which had
been previously built as a module is now built into the kernel.  In
that case, you really want to make sure the no-longer applicable .ko
file has been removed from the system.  If the developer knows that to
be true, they can use your proposed modules_update without any problems.

As a suggestion, something that might be worth trying would be to
change to modules_install so that it uses cp -u, but also so that it
tries to delete all files that could have previously installed as
modules (by using the obj-y list).  This should hopefully speed up
modules_install, and make it do the right thing all the time.

Regards,

						- Ted

  reply	other threads:[~2006-04-14 17:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-14 15:06 [PATCH] make: add modules_update target Kylene Jo Hall
2006-04-14 17:02 ` Theodore Ts'o [this message]
2006-04-14 18:00   ` Avi Kivity
2006-04-14 18:29     ` Dustin Kirkland
2006-04-14 19:02       ` Avi Kivity
2006-04-15  0:33         ` Dustin Kirkland
2006-04-15  0:33   ` Dustin Kirkland
2006-04-15  8:40     ` Sam Ravnborg
2006-04-15 15:02       ` Theodore Ts'o
2006-04-16 18:24         ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060414170222.GA19172@thunk.org \
    --to=tytso@mit.edu \
    --cc=dustin.kirkland@us.ibm.com \
    --cc=kbuild-devel@lists.sourceforge.net \
    --cc=kjhall@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox