From: Andi Kleen <ak@suse.de>
To: discuss@x86-64.org
Cc: "Jan Beulich" <jbeulich@novell.com>,
tom.l.nguyen@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [discuss] Re: [i386, x86-64] ioapic_register_intr() and assign_irq_vector() questions
Date: Fri, 14 Apr 2006 23:34:18 +0200 [thread overview]
Message-ID: <200604142334.18923.ak@suse.de> (raw)
In-Reply-To: <443FE6E00200007800015D6E@emea1-mh.id2.novell.com>
On Friday 14 April 2006 19:16, Jan Beulich wrote:
> >> Looking at the call paths assign_irq_vector() can get called from, I
> >> would think this function, namely as it's using static variables,
> >> lacks synchronization - is there any (hidden) reason this is not
> >> needed here?
>
> >It is only called during system initialization which is single threaded.
> >If someone added ioapic hotplug they would need to do something about
> >this.
>
> Hmm, as I looked through this I expected this to be possibly called also later, as it seems to be on paths reachable
> from exported functions (which clearly can be called only after the single-threaded phase is over.
If it's not called from in tree modules we don't care. But should probably
bunk the exports if they are not needed. Which ones were it?
-Andi
next prev parent reply other threads:[~2006-04-14 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-14 17:16 [i386, x86-64] ioapic_register_intr() and assign_irq_vector() questions Jan Beulich
2006-04-14 21:34 ` Andi Kleen [this message]
2006-04-20 10:52 ` [discuss] " Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604142334.18923.ak@suse.de \
--to=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.l.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox