Re: Improve PCI config space writeback.

Dave Jones
2006-04-17T01:16:58Z

On Mon, Apr 17, 2006 at 10:27:07AM +1000, Ben Herrenschmidt wrote:
> On Sun, 2006-04-16 at 17:42 -0500, Dave Jones wrote:
> > At least one laptop blew up on resume from suspend with a black screen
> > due to a lack of this patch. By only writing back config space that
> > is different, we minimise the possibility of accidents like this.
> >
> > Signed-off-by: Dave Jones <davej@redhat.com>
>
> I think it's a mistake to restore the command register before the rest.
> It should be restored last.

Adam Belay had a patch that did this, and a bunch of other similar
things (like making sure we never set BIST when restoring).

There are likely a number of similar possible improvements.

Dave

--