From: Jean Delvare <khali@linux-fr.org>
To: Linus Torvalds <torvalds@osdl.org>, Greg KH <greg@kroah.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
LM Sensors <lm-sensors@lm-sensors.org>
Subject: [PATCH] i2c-i801: Fix resume when PEC is used
Date: Tue, 18 Apr 2006 14:06:29 +0200 [thread overview]
Message-ID: <20060418140629.7cb21736.khali@linux-fr.org> (raw)
Fix for bug #6395:
Fail to resume on Tecra M2 with ADM1032 and Intel 82801DBM
The BIOS of the Tecra M2 doesn't like it when it has to reboot or
resume after the i2c-i801 driver has left the SMBus in PEC mode. So we
need to add proper .suspend, .resume and .shutdown callbacks to that
driver, where we clear and restore the PEC mode bit appropriately.
Thanks to Daniele Gaffuri for the very good report and contribution.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
drivers/i2c/busses/i2c-i801.c | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
--- linux-2.6.17-rc1.orig/drivers/i2c/busses/i2c-i801.c 2006-04-18 09:34:15.000000000 +0200
+++ linux-2.6.17-rc1/drivers/i2c/busses/i2c-i801.c 2006-04-18 12:47:07.000000000 +0200
@@ -110,6 +110,7 @@
static struct pci_driver i801_driver;
static struct pci_dev *I801_dev;
static int isich4;
+static u8 saved_auxctl;
static int i801_setup(struct pci_dev *dev)
{
@@ -551,17 +552,46 @@
return i2c_add_adapter(&i801_adapter);
}
+static void i801_shutdown(struct pci_dev *dev)
+{
+ if (isich4) {
+ /* Disable PEC mode before leaving, else some BIOSes will
+ fail to resume/reboot. */
+ outb_p(0, SMBAUXCTL);
+ }
+}
+
static void __devexit i801_remove(struct pci_dev *dev)
{
i2c_del_adapter(&i801_adapter);
+ i801_shutdown(dev);
release_region(i801_smba, (isich4 ? 16 : 8));
}
+static int i801_suspend(struct pci_dev *dev, pm_message_t state)
+{
+ i801_shutdown(dev);
+ return pci_save_state(dev);
+}
+
+static int i801_resume(struct pci_dev *dev)
+{
+ pci_restore_state(dev);
+ if (isich4) {
+ /* Restore PEC mode */
+ outb_p(saved_auxctl, SMBAUXCTL);
+ }
+ return 0;
+}
+
static struct pci_driver i801_driver = {
.name = "i801_smbus",
.id_table = i801_ids,
.probe = i801_probe,
.remove = __devexit_p(i801_remove),
+ .suspend = i801_suspend,
+ .resume = i801_resume,
+ .shutdown = i801_shutdown,
};
static int __init i2c_i801_init(void)
--
Jean Delvare
next reply other threads:[~2006-04-18 12:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-18 12:06 Jean Delvare [this message]
2006-04-18 17:03 ` [lm-sensors] [PATCH] i2c-i801: Fix resume when PEC is used Mark M. Hoffman
2006-04-18 19:15 ` Jean Delvare
2006-04-19 11:08 ` Jean Delvare
2006-04-19 16:19 ` Linus Torvalds
2006-04-19 18:30 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060418140629.7cb21736.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox