public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Ram Pai <linuxram@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, arjan@infradead.org,
	greg@kroah.com, hch@infradead.org
Subject: Re: [RFC PATCH 1/2] Makefile: export-symbol usage report generator.
Date: Tue, 18 Apr 2006 16:09:27 +0200	[thread overview]
Message-ID: <20060418140927.GB11582@stusta.de> (raw)
In-Reply-To: <20060413123826.52D94470030@localhost>

On Thu, Apr 13, 2006 at 05:38:26AM -0700, Ram Pai wrote:

> I ran a report to extract export-symbol usage by kernel modules.  The results
> are at http://www.sudhaa.com/~ram/misc/export_report.txt
> 
> The report lists:
> 1. All the exported symbols and their usage counts by in-kernel modules.
> 2. for each in-kernel module, lists the modules and the exported symbols
> 	from those modules, that it depends on.
> 
> Highlights: 
> 	On x86 architecture
>  	(1) 880 exported symbols not used by any in-kernel modules.
>         (2) 1792 exported symbols used only once.
> 
> I hope this report/tool shall help all inkernel modules to revisit their usage
> of kernel interfaces.
> 
> This patch integrates the report-generator into the kernel build process. After
> applying this patch, invoke 'make export_report'  and it creates the report in
> Documentation/export_report.txt
>...

I like your patch, but I have observed two issues:
- please don't force an allmodconfig, simply use the currently compiled
  kernel 
- please output to stdout instead of a fixed file

This way, it would also be consistent with other Makefile targets like 
namespacecheck.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2006-04-18 14:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-13 12:38 [RFC PATCH 1/2] Makefile: export-symbol usage report generator Ram Pai
2006-04-18 14:09 ` Adrian Bunk [this message]
2006-04-19 23:25   ` Ram Pai
2006-04-19 23:41     ` Adrian Bunk
2006-04-20  0:53       ` Ram Pai
2006-04-20  1:06         ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060418140927.GB11582@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=greg@kroah.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxram@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox