* [2.6 patch] drivers/char/ipmi/ipmi_msghandler.c: make proc_ipmi_root static
@ 2006-04-13 8:02 Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2006-04-13 8:02 UTC (permalink / raw)
To: minyard; +Cc: linux-kernel
This patch makes the needlessly global struct proc_ipmi_root static.
Besides this, it removes an unused #ifdef CONFIG_PROC_FS from
include/linux/ipmi.h.
---
BTW: Please add an entry for IPMI to MAINTAINERS.
drivers/char/ipmi/ipmi_msghandler.c | 3 +--
include/linux/ipmi.h | 4 ----
2 files changed, 1 insertion(+), 6 deletions(-)
--- linux-2.6.17-rc1-mm2-full/include/linux/ipmi.h.old 2006-04-12 22:32:08.000000000 +0200
+++ linux-2.6.17-rc1-mm2-full/include/linux/ipmi.h 2006-04-12 22:32:20.000000000 +0200
@@ -210,11 +210,7 @@
*/
#include <linux/list.h>
#include <linux/module.h>
-
-#ifdef CONFIG_PROC_FS
#include <linux/proc_fs.h>
-extern struct proc_dir_entry *proc_ipmi_root;
-#endif /* CONFIG_PROC_FS */
/* Opaque type for a IPMI message user. One of these is needed to
send and receive messages. */
--- linux-2.6.17-rc1-mm2-full/drivers/char/ipmi/ipmi_msghandler.c.old 2006-04-12 22:32:29.000000000 +0200
+++ linux-2.6.17-rc1-mm2-full/drivers/char/ipmi/ipmi_msghandler.c 2006-04-12 22:32:45.000000000 +0200
@@ -57,8 +57,7 @@
static int initialized = 0;
#ifdef CONFIG_PROC_FS
-struct proc_dir_entry *proc_ipmi_root = NULL;
-EXPORT_SYMBOL(proc_ipmi_root);
+static struct proc_dir_entry *proc_ipmi_root = NULL;
#endif /* CONFIG_PROC_FS */
#define MAX_EVENTS_IN_QUEUE 25
^ permalink raw reply [flat|nested] 3+ messages in thread
* [2.6 patch] drivers/char/ipmi/ipmi_msghandler.c: make proc_ipmi_root static
@ 2006-04-18 15:06 Adrian Bunk
2006-04-18 15:14 ` Corey Minyard
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2006-04-18 15:06 UTC (permalink / raw)
To: Andrew Morton; +Cc: minyard, linux-kernel
This patch makes the needlessly global struct proc_ipmi_root static.
Besides this, it removes an unused #ifdef CONFIG_PROC_FS from
include/linux/ipmi.h.
---
This patch was already sent on:
- 13 Apr 2006
BTW: Please add an entry for IPMI to MAINTAINERS.
drivers/char/ipmi/ipmi_msghandler.c | 3 +--
include/linux/ipmi.h | 4 ----
2 files changed, 1 insertion(+), 6 deletions(-)
--- linux-2.6.17-rc1-mm2-full/include/linux/ipmi.h.old 2006-04-12 22:32:08.000000000 +0200
+++ linux-2.6.17-rc1-mm2-full/include/linux/ipmi.h 2006-04-12 22:32:20.000000000 +0200
@@ -210,11 +210,7 @@
*/
#include <linux/list.h>
#include <linux/module.h>
-
-#ifdef CONFIG_PROC_FS
#include <linux/proc_fs.h>
-extern struct proc_dir_entry *proc_ipmi_root;
-#endif /* CONFIG_PROC_FS */
/* Opaque type for a IPMI message user. One of these is needed to
send and receive messages. */
--- linux-2.6.17-rc1-mm2-full/drivers/char/ipmi/ipmi_msghandler.c.old 2006-04-12 22:32:29.000000000 +0200
+++ linux-2.6.17-rc1-mm2-full/drivers/char/ipmi/ipmi_msghandler.c 2006-04-12 22:32:45.000000000 +0200
@@ -57,8 +57,7 @@
static int initialized = 0;
#ifdef CONFIG_PROC_FS
-struct proc_dir_entry *proc_ipmi_root = NULL;
-EXPORT_SYMBOL(proc_ipmi_root);
+static struct proc_dir_entry *proc_ipmi_root = NULL;
#endif /* CONFIG_PROC_FS */
#define MAX_EVENTS_IN_QUEUE 25
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] drivers/char/ipmi/ipmi_msghandler.c: make proc_ipmi_root static
2006-04-18 15:06 [2.6 patch] drivers/char/ipmi/ipmi_msghandler.c: make proc_ipmi_root static Adrian Bunk
@ 2006-04-18 15:14 ` Corey Minyard
0 siblings, 0 replies; 3+ messages in thread
From: Corey Minyard @ 2006-04-18 15:14 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, minyard, linux-kernel
Yes, I thought this had already been added. Please add it.
Thanks,
-Corey
Adrian Bunk wrote:
>This patch makes the needlessly global struct proc_ipmi_root static.
>
>Besides this, it removes an unused #ifdef CONFIG_PROC_FS from
>include/linux/ipmi.h.
>
>---
>
>This patch was already sent on:
>- 13 Apr 2006
>
>BTW: Please add an entry for IPMI to MAINTAINERS.
>
> drivers/char/ipmi/ipmi_msghandler.c | 3 +--
> include/linux/ipmi.h | 4 ----
> 2 files changed, 1 insertion(+), 6 deletions(-)
>
>--- linux-2.6.17-rc1-mm2-full/include/linux/ipmi.h.old 2006-04-12 22:32:08.000000000 +0200
>+++ linux-2.6.17-rc1-mm2-full/include/linux/ipmi.h 2006-04-12 22:32:20.000000000 +0200
>@@ -210,11 +210,7 @@
> */
> #include <linux/list.h>
> #include <linux/module.h>
>-
>-#ifdef CONFIG_PROC_FS
> #include <linux/proc_fs.h>
>-extern struct proc_dir_entry *proc_ipmi_root;
>-#endif /* CONFIG_PROC_FS */
>
> /* Opaque type for a IPMI message user. One of these is needed to
> send and receive messages. */
>--- linux-2.6.17-rc1-mm2-full/drivers/char/ipmi/ipmi_msghandler.c.old 2006-04-12 22:32:29.000000000 +0200
>+++ linux-2.6.17-rc1-mm2-full/drivers/char/ipmi/ipmi_msghandler.c 2006-04-12 22:32:45.000000000 +0200
>@@ -57,8 +57,7 @@
> static int initialized = 0;
>
> #ifdef CONFIG_PROC_FS
>-struct proc_dir_entry *proc_ipmi_root = NULL;
>-EXPORT_SYMBOL(proc_ipmi_root);
>+static struct proc_dir_entry *proc_ipmi_root = NULL;
> #endif /* CONFIG_PROC_FS */
>
> #define MAX_EVENTS_IN_QUEUE 25
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-04-18 15:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-18 15:06 [2.6 patch] drivers/char/ipmi/ipmi_msghandler.c: make proc_ipmi_root static Adrian Bunk
2006-04-18 15:14 ` Corey Minyard
-- strict thread matches above, loose matches on Subject: below --
2006-04-13 8:02 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox