From: Nigel Cunningham <ncunningham@cyclades.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>, Pavel Machek <pavel@ucw.cz>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 2/3] swsusp i386 mark special saveable/unsaveable pages
Date: Wed, 19 Apr 2006 08:38:19 +1000 [thread overview]
Message-ID: <200604190838.29247.ncunningham@cyclades.com> (raw)
In-Reply-To: <1144809501.2865.40.camel@sli10-desk.sh.intel.com>
[-- Attachment #1: Type: text/plain, Size: 628 bytes --]
Hi.
On Wednesday 12 April 2006 12:38, Shaohua Li wrote:
> @@ -1400,6 +1401,111 @@ static void set_mca_bus(int x)
> static void set_mca_bus(int x) { }
> #endif
>
> +#ifdef CONFIG_SOFTWARE_SUSPEND
> +static void __init mark_nosave_page_range(unsigned long start, unsigned
> long end) +{
> + struct page *page;
> + while (start <= end) {
Should this be start < end? (End is usually the first byte of the next zone
IIUC).
> + page = pfn_to_page(start);
> + SetPageNosave(page);
> + start++;
> + }
> +}
> +
> +static void __init e820_nosave_reserved_pages(void)
> +{
> + int i;
Regards,
Nigel
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-04-18 22:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-12 2:38 [PATCH 2/3] swsusp i386 mark special saveable/unsaveable pages Shaohua Li
2006-04-18 22:38 ` Nigel Cunningham [this message]
2006-04-19 1:22 ` Shaohua Li
2006-04-19 1:41 ` Nigel Cunningham
2006-04-19 1:51 ` Shaohua Li
2006-04-19 2:08 ` Nigel Cunningham
2006-04-19 2:53 ` Shaohua Li
2006-04-19 2:59 ` Nigel Cunningham
2006-04-19 3:28 ` Shaohua Li
2006-04-19 6:33 ` Nigel Cunningham
2006-04-20 3:08 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604190838.29247.ncunningham@cyclades.com \
--to=ncunningham@cyclades.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox