From: Jean Delvare <khali@linux-fr.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Greg KH <greg@kroah.com>,
"Mark M. Hoffman" <mhoffman@lightlink.com>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [PATCH] i2c-i801: Fix resume when PEC is used
Date: Wed, 19 Apr 2006 20:30:31 +0200 [thread overview]
Message-ID: <20060419203031.b20e967c.khali@linux-fr.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0604190918210.3701@g5.osdl.org>
Hi Linus,
> On Wed, 19 Apr 2006, Jean Delvare wrote:
> > The BIOS of the Tecra M2 doesn't like it when it has to reboot or
> > resume after the i2c-i801 driver has left the SMBus in PEC mode. The
> > most simple fix is to clear the PEC bit after after every transaction.
The same day, Linus Torvalds replied:
> Just wondering.. Wouldn't it make more sense to clear it when closing the
> device or when shutting down, rather than after each transaction?
That's what my original patch was doing, but Mark M. Hoffman objected
that it didn't cover the case where the user hits the reset button.
Given that PEC is only rarely used, the slight performance impact isn't
an issue, so I'm fine with both patches.
--
Jean Delvare
prev parent reply other threads:[~2006-04-19 18:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-18 12:06 [PATCH] i2c-i801: Fix resume when PEC is used Jean Delvare
2006-04-18 17:03 ` [lm-sensors] " Mark M. Hoffman
2006-04-18 19:15 ` Jean Delvare
2006-04-19 11:08 ` Jean Delvare
2006-04-19 16:19 ` Linus Torvalds
2006-04-19 18:30 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060419203031.b20e967c.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mhoffman@lightlink.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox