From: Keshavamurthy Anil S <anil.s.keshavamurthy@intel.com>
To: Keith Owens <kaos@ocs.com.au>
Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
Anderw Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>, Keith Owens <kaos@sgi.com>,
Dean Nelson <dcn@sgi.com>, Tony Luck <tony.luck@intel.com>,
Ananth Mavinakayanahalli <ananth@in.ibm.com>,
Prasanna Panchamukhi <prasanna@in.ibm.com>,
Dave M <davem@davemloft.net>, Andi Kleen <ak@suse.de>,
Robin Holt <holt@sgi.com>
Subject: Re: [(resend)patch 3/7] Notify page fault call chain for ia64
Date: Wed, 19 Apr 2006 21:47:49 -0700 [thread overview]
Message-ID: <20060419214748.B6150@unix-os.sc.intel.com> (raw)
In-Reply-To: <7375.1145499505@kao2.melbourne.sgi.com>; from kaos@ocs.com.au on Thu, Apr 20, 2006 at 12:18:25PM +1000
On Thu, Apr 20, 2006 at 12:18:25PM +1000, Keith Owens wrote:
> Why is register_page_fault_notifier defined in traps.c? Surely it
> should be in mm/fault.c, which is the only place that uses the chain.
Ah..that is because I blindly followed {register/unregister}_die_notifier()
implementation. It can moved to mm/faults.c and I will rework my patch.
>
> > trap_init (void)
> > {
> >Index: linux-2.6.17-rc1-mm3/arch/ia64/mm/fault.c
> >===================================================================
> >--- linux-2.6.17-rc1-mm3.orig/arch/ia64/mm/fault.c
> >+++ linux-2.6.17-rc1-mm3/arch/ia64/mm/fault.c
> >@@ -84,7 +84,7 @@ ia64_do_page_fault (unsigned long addres
> > /*
> > * This is to handle the kprobes on user space access instructions
> > */
> >- if (notify_die(DIE_PAGE_FAULT, "page fault", regs, code, TRAP_BRKPT,
> >+ if (notify_page_fault(DIE_PAGE_FAULT, "page fault", regs, code, TRAP_BRKPT,
> > SIGSEGV) == NOTIFY_STOP)
> > return;
>
> Since this is a critical path, please remove all references to
> notify_page_fault() and its register functions when CONFIG_KPROBES=n.
Yes, I agree with you and thanks for your feedback.
-Anil
next prev parent reply other threads:[~2006-04-20 4:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-19 22:14 [(resend)patch 0/7] Notify page fault call chain Anil S Keshavamurthy
2006-04-19 22:14 ` [(resend)patch 1/7] Notify page fault call chain for i386 Anil S Keshavamurthy
2006-04-19 22:14 ` [(resend)patch 2/7] Notify page fault call chain for x86_64 Anil S Keshavamurthy
2006-04-19 22:14 ` [(resend)patch 3/7] Notify page fault call chain for ia64 Anil S Keshavamurthy
2006-04-20 2:18 ` Keith Owens
2006-04-20 4:47 ` Keshavamurthy Anil S [this message]
2006-04-19 22:14 ` [(resend)patch 4/7] Notify page fault call chain for powerpc Anil S Keshavamurthy
2006-04-19 22:14 ` [(resend)patch 5/7] Notify page fault call chain for sparc64 Anil S Keshavamurthy
2006-04-19 22:14 ` [(resend)patch 6/7] Kprobes registers for notify page fault Anil S Keshavamurthy
2006-04-19 22:14 ` [(resend)patch 7/7] Kprobes - Register for page fault notify on active probes Anil S Keshavamurthy
2006-04-20 3:57 ` Ananth N Mavinakayanahalli
2006-04-20 4:53 ` Keshavamurthy Anil S
2006-04-20 0:27 ` [(resend)patch 0/7] Notify page fault call chain Keith Owens
2006-04-20 4:37 ` Keshavamurthy Anil S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060419214748.B6150@unix-os.sc.intel.com \
--to=anil.s.keshavamurthy@intel.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=ananth@in.ibm.com \
--cc=davem@davemloft.net \
--cc=dcn@sgi.com \
--cc=holt@sgi.com \
--cc=kaos@ocs.com.au \
--cc=kaos@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prasanna@in.ibm.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox