From: Andrew Morton <akpm@osdl.org>
To: Tilman Schmidt <tilman@imap.cc>
Cc: kkeil@suse.de, isdn4linux@listserv.isdn4linux.de,
linux-kernel@vger.kernel.org, hjlipp@web.de
Subject: Re: [2.6 Patch] isdn4linux: Siemens Gigaset base driver: fix disconnect handling
Date: Thu, 20 Apr 2006 00:11:06 -0700 [thread overview]
Message-ID: <20060420001106.23d08ca7.akpm@osdl.org> (raw)
In-Reply-To: <200604191838.k3JIc1eX022982@lx1.pxnet.com>
Tilman Schmidt <tilman@imap.cc> wrote:
>
> This patch fixes a possible Oops in the Siemens Gigaset base driver when
> the device is unplugged while an ISDN connection is still active, and
> makes sure that the isdn4linux link level (LL) is properly informed if a
> connection is broken by the USB cable being unplugged.
> It also improves some kernel messages generated by the driver.
It seems to do quite a lot more than that.
> Please merge at your earliest convenience.
Well OK, but I'd ask you to confirm that this was actually the patch which
was supposed to go with that changelog.
> --- linux-2.6.17-rc2-work/drivers/isdn/gigaset.orig/bas-gigaset.c 2006-04-19 15:15:49.000000000 +0200
> +++ local/drivers/isdn/gigaset/bas-gigaset.c 2006-04-19 01:19:41.000000000 +0200
eek, please don't do that - it confuses my scripts.
--- linux-2.6.17-rc2-work/drivers/isdn/gigaset/bas-gigaset.c
+++ linux-2.6.17-rc2-work/drivers/isdn/gigaset/bas-gigaset.c
is preferred. There are nice tools around which help with this.
next prev parent reply other threads:[~2006-04-20 7:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-19 18:38 [2.6 Patch] isdn4linux: Siemens Gigaset base driver: fix disconnect handling Tilman Schmidt
2006-04-20 7:11 ` Andrew Morton [this message]
2006-04-20 12:07 ` Tilman Schmidt
2006-04-20 15:21 ` Randy.Dunlap
2006-04-20 15:32 ` Adrian Bunk
2006-04-20 16:14 ` Randy.Dunlap
2006-04-20 18:29 ` Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060420001106.23d08ca7.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=hjlipp@web.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox