[RFC: 2.6 patch] let arm use drivers/Kconfig

[RFC: 2.6 patch] let arm use drivers/Kconfig

[Adrian Bunk]

This patch lets arm use drivers/Kconfig.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 arch/arm/Kconfig    |   75 --------------------------------------------
 drivers/Kconfig     |    2 +
 drivers/mtd/Kconfig |    1 
 3 files changed, 4 insertions(+), 74 deletions(-)

--- linux-2.6.17-rc1-mm2-arm/arch/arm/Kconfig.old	2006-04-17 14:25:08.000000000 +0200
+++ linux-2.6.17-rc1-mm2-arm/arch/arm/Kconfig	2006-04-17 14:54:15.000000000 +0200
@@ -794,80 +794,7 @@
 
 source "net/Kconfig"
 
-menu "Device Drivers"
-
-source "drivers/base/Kconfig"
-
-source "drivers/connector/Kconfig"
-
-if ALIGNMENT_TRAP
-source "drivers/mtd/Kconfig"
-endif
-
-source "drivers/parport/Kconfig"
-
-source "drivers/pnp/Kconfig"
-
-source "drivers/block/Kconfig"
-
-source "drivers/acorn/block/Kconfig"
-
-if PCMCIA || ARCH_CLPS7500 || ARCH_IOP3XX || ARCH_IXP4XX \
-	|| ARCH_L7200 || ARCH_LH7A40X || ARCH_PXA || ARCH_RPC \
-	|| ARCH_S3C2410 || ARCH_SA1100 || ARCH_SHARK || FOOTBRIDGE \
-	|| ARCH_IXP23XX
-source "drivers/ide/Kconfig"
-endif
-
-source "drivers/scsi/Kconfig"
-
-source "drivers/md/Kconfig"
-
-source "drivers/message/fusion/Kconfig"
-
-source "drivers/ieee1394/Kconfig"
-
-source "drivers/message/i2o/Kconfig"
-
-source "drivers/net/Kconfig"
-
-source "drivers/isdn/Kconfig"
-
-# input before char - char/joystick depends on it. As does USB.
-
-source "drivers/input/Kconfig"
-
-source "drivers/char/Kconfig"
-
-source "drivers/i2c/Kconfig"
-
-source "drivers/spi/Kconfig"
-
-source "drivers/w1/Kconfig"
-
-source "drivers/hwmon/Kconfig"
-
-#source "drivers/l3/Kconfig"
-
-source "drivers/misc/Kconfig"
-
-source "drivers/mfd/Kconfig"
-
-source "drivers/leds/Kconfig"
-
-source "drivers/media/Kconfig"
-
-source "drivers/video/Kconfig"
-
-source "sound/Kconfig"
-
-source "drivers/usb/Kconfig"
-
-source "drivers/mmc/Kconfig"
-
-source "drivers/rtc/Kconfig"
-
-endmenu
+source "drivers/Kconfig"
 
 source "fs/Kconfig"
 
--- linux-2.6.17-rc1-mm2-arm/drivers/mtd/Kconfig.old	2006-04-17 14:32:35.000000000 +0200
+++ linux-2.6.17-rc1-mm2-arm/drivers/mtd/Kconfig	2006-04-17 15:00:57.000000000 +0200
@@ -1,6 +1,7 @@
 # $Id: Kconfig,v 1.11 2005/11/07 11:14:19 gleixner Exp $
 
 menu "Memory Technology Devices (MTD)"
+	depends on (ALIGNMENT_TRAP || !ARM)
 
 config MTD
 	tristate "Memory Technology Device (MTD) support"
--- linux-2.6.17-rc1-mm2-arm/drivers/Kconfig.old	2006-04-17 14:51:25.000000000 +0200
+++ linux-2.6.17-rc1-mm2-arm/drivers/Kconfig	2006-04-17 14:51:38.000000000 +0200
@@ -14,6 +14,8 @@
 
 source "drivers/block/Kconfig"
 
+source "drivers/acorn/block/Kconfig"
+
 source "drivers/ide/Kconfig"
 
 source "drivers/scsi/Kconfig"

Re: [RFC: 2.6 patch] let arm use drivers/Kconfig

[David Woodhouse]

On Mon, 2006-04-17 at 16:48 +0200, Adrian Bunk wrote:
> --- linux-2.6.17-rc1-mm2-arm/drivers/mtd/Kconfig.old    2006-04-17 14:32:35.000000000 +0200
> +++ linux-2.6.17-rc1-mm2-arm/drivers/mtd/Kconfig        2006-04-17 15:00:57.000000000 +0200
> @@ -1,6 +1,7 @@
>  # $Id: Kconfig,v 1.11 2005/11/07 11:14:19 gleixner Exp $
>  
>  menu "Memory Technology Devices (MTD)"
> +       depends on (ALIGNMENT_TRAP || !ARM)
>  
>  config MTD
>         tristate "Memory Technology Device (MTD) support"

This dependency is incorrect. It's only one or two chip-specific drivers
which require that the architecture correctly handle alignment traps,
and even then it's only actually apparent when used with JFFS2 which
actually _gives_ it an unaligned buffer occasionally. Everything else
works fine.

Also, I don't want to see this dependency expressed in the MTD Kconfig
file unless it's not arch-specific. Please make a generic
BROKEN_UNALIGNED config option, and set it on all architectures which
need it. Then propose a saner place to put the restriction instead of on
CONFIG_MTD.

-- 
dwmw2

Re: [RFC: 2.6 patch] let arm use drivers/Kconfig

[Adrian Bunk]

On Mon, Apr 17, 2006 at 03:55:54PM +0100, David Woodhouse wrote:
> On Mon, 2006-04-17 at 16:48 +0200, Adrian Bunk wrote:
> > --- linux-2.6.17-rc1-mm2-arm/drivers/mtd/Kconfig.old    2006-04-17 14:32:35.000000000 +0200
> > +++ linux-2.6.17-rc1-mm2-arm/drivers/mtd/Kconfig        2006-04-17 15:00:57.000000000 +0200
> > @@ -1,6 +1,7 @@
> >  # $Id: Kconfig,v 1.11 2005/11/07 11:14:19 gleixner Exp $
> >  
> >  menu "Memory Technology Devices (MTD)"
> > +       depends on (ALIGNMENT_TRAP || !ARM)
> >  
> >  config MTD
> >         tristate "Memory Technology Device (MTD) support"
> 
> This dependency is incorrect. It's only one or two chip-specific drivers
> which require that the architecture correctly handle alignment traps,
> and even then it's only actually apparent when used with JFFS2 which
> actually _gives_ it an unaligned buffer occasionally. Everything else
> works fine.
> 
> Also, I don't want to see this dependency expressed in the MTD Kconfig
> file unless it's not arch-specific. Please make a generic
> BROKEN_UNALIGNED config option, and set it on all architectures which
> need it. Then propose a saner place to put the restriction instead of on
> CONFIG_MTD.

Can anyone tell me which chip-specific drivers are affected by this 
issue so that I can send a patch?

> dwmw2

TIA
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [RFC: 2.6 patch] let arm use drivers/Kconfig

[David Woodhouse]

On Thu, 2006-04-20 at 14:06 +0200, Adrian Bunk wrote:
> > This dependency is incorrect. It's only one or two chip-specific drivers
> > which require that the architecture correctly handle alignment traps,
> > and even then it's only actually apparent when used with JFFS2 which
> > actually _gives_ it an unaligned buffer occasionally. Everything else
> > works fine.
>
> Can anyone tell me which chip-specific drivers are affected by this 
> issue so that I can send a patch?

Disabling those chip drivers isn't necessarily the answer, since they
can still be used in most cases; just not for JFFS2. Perhaps we should
just disable JFFS2 if BROKEN_UNALIGNED is set -- or disable JFFS2 on NOR
flash if it's set. 

Get the generic BROKEN_UNALIGNED thing done across all architectures
which need it, and we'll work out precisely where to use it.

-- 
dwmw2

Re: [RFC: 2.6 patch] let arm use drivers/Kconfig

[Jörn Engel]

On Thu, 20 April 2006 21:54:11 +0100, David Woodhouse wrote:
> On Thu, 2006-04-20 at 14:06 +0200, Adrian Bunk wrote:
> > > This dependency is incorrect. It's only one or two chip-specific drivers
> > > which require that the architecture correctly handle alignment traps,
> > > and even then it's only actually apparent when used with JFFS2 which
> > > actually _gives_ it an unaligned buffer occasionally. Everything else
> > > works fine.
> >
> > Can anyone tell me which chip-specific drivers are affected by this 
> > issue so that I can send a patch?
> 
> Disabling those chip drivers isn't necessarily the answer, since they
> can still be used in most cases; just not for JFFS2. Perhaps we should
> just disable JFFS2 if BROKEN_UNALIGNED is set -- or disable JFFS2 on NOR
> flash if it's set. 

mtd->flags would be a good place for that.  Unlike many other things
previously in there, it is a device property that matters.

Jörn

-- 
Data expands to fill the space available for storage.
-- Parkinson's Law