public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andi Kleen <ak@suse.de>
Cc: discuss@x86-64.org, "Randy.Dunlap" <rdunlap@xenotime.net>,
	torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [discuss] Re: [PATCH] [6/6] i386: Move CONFIG_DOUBLEFAULT into arch/i386 where it belongs.
Date: Thu, 20 Apr 2006 15:47:51 +0200	[thread overview]
Message-ID: <20060420134751.GS25047@stusta.de> (raw)
In-Reply-To: <200604201526.22318.ak@suse.de>

On Thu, Apr 20, 2006 at 03:26:21PM +0200, Andi Kleen wrote:
> On Thursday 20 April 2006 13:49, Adrian Bunk wrote:
> 
> > My main problem with his patch is still the way he did it - sending a 
> > patch reverting a recently included patch with neither discussion before 
> > the patch nor mentioning in the patch that it's a revert nor a Cc to the 
> > people involved with the patch.
> 
> I just noticed a problem (bogus symbols in my x86-64 config) and fixed it. I normally 
> don't look at which patch it introduced for such trivial changes.

First of all, the "problem" of an unset config variable in the .config 
is at most a cosmetical issue.

And even if it had been a real problem, discussing such an issue and 
convincing people why you consider it to be bad is always better, since 
whoever gets conviced in the situation will have learned for similar 
future cases.

There are ways how things should work and we should follow them.

As an example, there is one trivial x86_64 specific patch removing the 
small bloat caused by an unused export I made in -mm Andrew has 
forwarded at least twice to you.

Until now, I'd have considered it an unfriendly act to forward such a 
patch to Linus through my trivial tree bypassing you as the maintainer, 
but looking at your statement it seems to be OK for you if I send such 
trivial patches directly to Linus without bothering to go through you as 
the maintainer.

> -Andi

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


      reply	other threads:[~2006-04-20 13:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-18 10:35 [PATCH] [6/6] i386: Move CONFIG_DOUBLEFAULT into arch/i386 where it belongs Andi Kleen
2006-04-18 19:05 ` Adrian Bunk
2006-04-18 20:12   ` [discuss] " Andi Kleen
2006-04-19  2:08     ` Randy.Dunlap
2006-04-20 11:49       ` Adrian Bunk
2006-04-20 13:26         ` Andi Kleen
2006-04-20 13:47           ` Adrian Bunk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060420134751.GS25047@stusta.de \
    --to=bunk@stusta.de \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=discuss@x86-64.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox