From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751025AbWDTPci (ORCPT ); Thu, 20 Apr 2006 11:32:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751028AbWDTPci (ORCPT ); Thu, 20 Apr 2006 11:32:38 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:56845 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S1751026AbWDTPch (ORCPT ); Thu, 20 Apr 2006 11:32:37 -0400 Date: Thu, 20 Apr 2006 17:32:36 +0200 From: Adrian Bunk To: "Randy.Dunlap" Cc: Tilman Schmidt , akpm@osdl.org, kkeil@suse.de, i4ldeveloper@listserv.isdn4linux.de, linux-kernel@vger.kernel.org, hjlipp@web.de, gregkh@suse.de, linux-usb-devel@lists.sourceforge.net Subject: Re: [2.6 Patch] isdn4linux: Siemens Gigaset base driver: fix disconnect handling Message-ID: <20060420153236.GU25047@stusta.de> References: <200604191838.k3JIc1eX022982@lx1.pxnet.com> <20060420001106.23d08ca7.akpm@osdl.org> <4447796F.1070307@imap.cc> <20060420082120.57ae9ac5.rdunlap@xenotime.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060420082120.57ae9ac5.rdunlap@xenotime.net> User-Agent: Mutt/1.5.11+cvs20060403 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 20, 2006 at 08:21:20AM -0700, Randy.Dunlap wrote: > On Thu, 20 Apr 2006 14:07:11 +0200 Tilman Schmidt wrote: > > > On 20.04.2006 09:11, Andrew Morton wrote: > > > Tilman Schmidt wrote: > > > > > >>This patch fixes a possible Oops in the Siemens Gigaset base driver when > > >> the device is unplugged while an ISDN connection is still active, and > > >> makes sure that the isdn4linux link level (LL) is properly informed if a > > >> connection is broken by the USB cable being unplugged. > > >> It also improves some kernel messages generated by the driver. > > > > > > It seems to do quite a lot more than that. > > > [...] I'd ask you to confirm that this was actually the patch which > > > was supposed to go with that changelog. > > > > It is. However the changelog was not quite complete. There were a couple > > of smaller changes which I neglected to mention. Sorry for that. I'll > > try to be more careful when composing future changelogs. > > ... > > > >> --- linux-2.6.17-rc2-work/drivers/isdn/gigaset.orig/bas-gigaset.c 2006-04-19 15:15:49.000000000 +0200 > > >> +++ local/drivers/isdn/gigaset/bas-gigaset.c 2006-04-19 01:19:41.000000000 +0200 > > > > > > eek, please don't do that - it confuses my scripts. > > > > > > --- linux-2.6.17-rc2-work/drivers/isdn/gigaset/bas-gigaset.c > > > +++ linux-2.6.17-rc2-work/drivers/isdn/gigaset/bas-gigaset.c > > > > > > is preferred. There are nice tools around which help with this. > > > > I'll be happy to comply with whatever your scripts need, but I don't > > quite understand yet what it is that's causing you problems: > > The presence of file timestamps? > > The timestamp of the second file being earlier than the first one? > > The ".orig" suffix in the first path? > > The second path starting with "local" instead of "linux-..."? > > All of this can be easily corrected; just tell me what's required. > > Both filename lines should begin one level above "drivers/". > They can be named linux* or a/ and b/ or foo/ and bar/ or whatever. > The patch needs to apply using "patch -p1". >... His patch already was nearly correct. The only thing that is wrong is linux-2.6.17-rc2-work/drivers/isdn/gigaset.orig/bas-gigaset.c ^^^^^ If anything else confused Andrew's scripts, he'd better fix his scripts. > ~Randy cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed