From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751096AbWDTQoZ (ORCPT ); Thu, 20 Apr 2006 12:44:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751094AbWDTQoZ (ORCPT ); Thu, 20 Apr 2006 12:44:25 -0400 Received: from cavan.codon.org.uk ([217.147.92.49]:62103 "EHLO vavatch.codon.org.uk") by vger.kernel.org with ESMTP id S1751079AbWDTQoY (ORCPT ); Thu, 20 Apr 2006 12:44:24 -0400 Date: Thu, 20 Apr 2006 17:44:19 +0100 From: Matthew Garrett To: Alexey Starikovskiy Cc: Xavier Bestel , "Yu, Luming" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC] [PATCH] Make ACPI button driver an input device Message-ID: <20060420164419.GA30317@srcf.ucam.org> References: <554C5F4C5BA7384EB2B412FD46A3BAD1332980@pdsmsx411.ccr.corp.intel.com> <20060420073713.GA25735@srcf.ucam.org> <4447AA59.8010300@linux.intel.com> <20060420153848.GA29726@srcf.ucam.org> <4447AF4D.7030507@linux.intel.com> <1145549460.23837.156.camel@capoeira> <4447B7D6.4030401@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4447B7D6.4030401@linux.intel.com> User-Agent: Mutt/1.5.9i X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@codon.org.uk X-SA-Exim-Scanned: No (on vavatch.codon.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 20, 2006 at 08:33:26PM +0400, Alexey Starikovskiy wrote: > Xavier Bestel wrote: > >There are keyboards with power/sleep buttons. It makes sense they have > >the same behavior than ACPI buttons. > Agree, make them behave like ACPI buttons -- remove them from input stream, > as they do not belong there... Making the atkbd driver punt certain scancodes to the ACPI layer /really/ isn't the right answer. -- Matthew Garrett | mjg59@srcf.ucam.org