Re: [RFC: 2.6 patch] kernel/sys.c: possible cleanups

Andrew Morton
2006-05-01T07:43:37Z

Adrian Bunk <bunk@stusta.de> wrote:
>
> On Mon, May 01, 2006 at 12:18:03AM -0700, Andrew Morton wrote:
> > Adrian Bunk <bunk@stusta.de> wrote:
> > >
> > > This patch contains the following possible cleanups:
> >
> > Please avoid mixing together cleanups
> >
> > > - proper prototypes for the following functions:
> > > - ctrl_alt_del() (in include/linux/reboot.h)
> > > - getrusage() (in include/linux/resource.h)
> > > - make the following needlessly global functions static:
> > > - kernel_restart_prepare()
> > > - kernel_kexec()
> >
> > which I will apply, together with API changes
>
> Are you splitting the patch yourself or should I send a splitted patch?

I currently have queued:

drivers/char/hw_random.c: remove assert()'s
drivers/char/applicom.c: proper module_{init,exit}
fs/buffer.c: possible cleanups
fs/open.c: unexport sys_openat

So please redo and resend the rest.

No particular hurry - I'll be out of the patch business for the next week.

> > > - remove the following unused EXPORT_SYMBOL:
> > > - in_egroup_p
> > > - remove the following unused EXPORT_SYMBOL_GPL's:
> > > - kernel_restart
> > > - kernel_halt
> >
> > which I will not.
> >
> > We have a process for the latter. And even if we ignore that process, the
> > patch ends up sitting in -mm for ages because of the API change, along with
> > the cleanups, which could be merged up promptly.
>
> The problem is that we have a lack of a process at the other end:
>
> There is no process to review added exports.

Yes there is - I and many others frequently query them. Sure, sometimes
stuff slips through. But it's a very very minor problem.