Re: [(take 2)patch 6/7] Kprobes registers for notify page fault

Keshavamurthy Anil S
2006-04-21T00:41:16Z

On Fri, Apr 21, 2006 at 10:14:04AM +1000, Keith Owens wrote:
> Anil S Keshavamurthy (on Thu, 20 Apr 2006 16:25:02 -0700) wrote:
> >---
> >@@ -654,6 +659,9 @@ static int __init init_kprobes(void)
> > if (!err)
> > err = register_die_notifier(&kprobe_exceptions_nb);
> >
> >+ if (!err)
> >+ err = register_page_fault_notifier(&kprobe_page_fault_nb);
> >+
> > return err;
> > }
> >
>
> The rest of the patches look OK, but this one does not. init_kprobes()
> registers the main kprobe exception handler, not the page fault
> handler.
I am registering for register_page_fault_notifier() and as you can see
I am not deleting the old register_die_notifier() which is also required
for getting notified on int3/break and single-step traps.
So no issues here.

>
> Now that there is a dedicated page fault handler, instead of being a
> subcase of notify_die(), it might be better to delete DIE_PAGE_FAULT
> completely. That can be done in this patch set or in some follow on
> patches.
It can be done as a follow up (cleanup patch) and if you see the whole
whole DIE_XXXX is grossly missnamed. I did not want to address two many
things in one patch.

thanks,
-Anil Keshavamurthy