From: Stephen Hemminger <shemminger@osdl.org>
To: linux-kernel@vger.kernel.org
Subject: Re: [patch 05/22] : Fix hotplug race during device registration
Date: Fri, 21 Apr 2006 10:44:33 -0700 [thread overview]
Message-ID: <20060421104433.0ff85977@localhost.localdomain> (raw)
In-Reply-To: 20060421135219.37720.qmail@web52901.mail.yahoo.com
On Fri, 21 Apr 2006 14:52:19 +0100 (BST)
Chris Rankin <rankincj@yahoo.com> wrote:
> --- "Alexander E. Patrakov" <patrakov@ums.usu.ru> wrote:
> > Look at the old code again. This is not a new bug. The old code fails
> > registration, does a printk, and then sets dev->reg_state = NETREG_REGISTERED.
>
> OK, fair enough. But anyway, is it valid to leave reg_state as NETREG_REGISTERED when the
> registration has failed?
Yes. the device is still half alive in that case. It is accessible via normal networking
calls, and can be unregistered. It just would not show up properly in sysfs.
Not sure how it would be possible (except maybe out of memory) to construct a case
where registration fails. Maybe races with name changes.
next prev parent reply other threads:[~2006-04-21 17:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-21 12:53 [patch 05/22] : Fix hotplug race during device registration Chris Rankin
2006-04-21 13:19 ` Alexander E. Patrakov
2006-04-21 14:54 ` Chris Rankin
2006-04-21 13:21 ` Alexander E. Patrakov
2006-04-21 13:52 ` Chris Rankin
2006-04-21 17:44 ` Stephen Hemminger [this message]
[not found] <20060421043353.602539000@blue.kroah.org>
2006-04-21 4:37 ` [patch 00/22] 2.6.16-stable review cycle Greg KH
2006-04-21 4:37 ` [patch 05/22] : Fix hotplug race during device registration Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060421104433.0ff85977@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox