From: Arnd Bergmann <arnd@arndb.de>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Andrew Morton <akpm@osdl.org>, Jens Axboe <axboe@suse.de>,
linux-kernel@vger.kernel.org, torvalds@osdl.org,
davem@davemloft.net, Paul Mackerras <paulus@samba.org>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] fix spu_callbacks BUILD_BUG_ON
Date: Fri, 21 Apr 2006 15:52:38 +0200 [thread overview]
Message-ID: <200604211552.38923.arnd@arndb.de> (raw)
In-Reply-To: <Pine.LNX.4.61.0604211512370.23180@yvahk01.tjqt.qr>
On Friday 21 April 2006 15:14, Jan Engelhardt wrote:
> + [__NR_syscalls] = NULL,
>
> > };
> >
> >- if (s->nr_ret >= __NR_syscalls) {
> >+ if (s->nr_ret >= ARRAY_SIZE(spu_syscall_table)) {
>
> + if(syscall == NULL) {
>
>
>
> That way, syscalls could be added in the master table while spu does not
> break. Comments?
Hmm, my idea was not having to check for NULL pointers when we know
that they are valid function calls. But you are right that your approach
is more robust. It also means that we might just leave out all
the assignments to sys_ni_syscall in order to make the source a little
shorter.
Arnd <><
next prev parent reply other threads:[~2006-04-21 13:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-21 8:02 [PATCH] sys_vmsplice Jens Axboe
2006-04-21 9:17 ` Andrew Morton
2006-04-21 9:21 ` Jens Axboe
2006-04-21 9:25 ` Andrew Morton
2006-04-21 9:52 ` Jens Axboe
2006-04-21 10:41 ` Arnd Bergmann
2006-04-21 10:45 ` [PATCH] fix spu_callbacks BUILD_BUG_ON Arnd Bergmann
2006-04-21 13:14 ` Jan Engelhardt
2006-04-21 13:52 ` Arnd Bergmann [this message]
2006-04-21 20:45 ` [PATCH] sys_vmsplice Linus Torvalds
2006-04-21 21:01 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604211552.38923.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=davem@davemloft.net \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox