From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932423AbWDUQ4b (ORCPT ); Fri, 21 Apr 2006 12:56:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932421AbWDUQ4b (ORCPT ); Fri, 21 Apr 2006 12:56:31 -0400 Received: from mail.kroah.org ([69.55.234.183]:4779 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S932418AbWDUQ4a (ORCPT ); Fri, 21 Apr 2006 12:56:30 -0400 Date: Fri, 21 Apr 2006 09:50:50 -0700 From: Greg KH To: Linus Torvalds Cc: Chris Wright , Stephen Smalley , Christoph Hellwig , tonyj@suse.de, James Morris , Jan Engelhardt , Andrew Morton , T?r?k Edwin , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] make security_ops EXPORT_SYMBOL_GPL() Message-ID: <20060421165050.GA11333@kroah.com> References: <20060420150037.GA30353@kroah.com> <1145542811.3313.94.camel@moss-spartans.epoch.ncsc.mil> <20060420161552.GA1990@kroah.com> <20060420162309.GA18726@infradead.org> <1145550897.3313.143.camel@moss-spartans.epoch.ncsc.mil> <20060420164651.GA2439@kroah.com> <1145552412.3313.150.camel@moss-spartans.epoch.ncsc.mil> <20060420170153.GA3237@kroah.com> <20060420193423.GA8456@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060420193423.GA8456@kroah.com> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 20, 2006 at 12:34:23PM -0700, Greg KH wrote: > On Thu, Apr 20, 2006 at 11:08:23AM -0700, Linus Torvalds wrote: > > If people want to remove security_ops, that's fine (not for 2.6.17, but > > assuming you guys can come to some reasonable agreement, at some later > > date). But turning it into a GPL-only, but leaving all the infrastructure > > requiring it is not. > > Fair enough, I'll work toward removing security_ops so that it is no > longer needed at all. Ok, that was pretty foolish of me to attempt. We could move all of the inline functions in security.h to a .c file for when the LSM framework is enabled, but that might cause some slowdowns. Although I remember that Kurt Garloff did some work in this area in the past, showing that moving these out of inline caused some improvements on ia64. Anyway, for now I'm not going to worry about this, it isn't that important... Sorry for the noise. greg k-h