Re: [PATCH 13/16] GFS2: Makefiles and Kconfig

Matthew Wilcox
2006-04-21T17:07:59Z

On Fri, Apr 21, 2006 at 06:53:51PM +0200, Adrian Bunk wrote:
> On Fri, Apr 21, 2006 at 10:49:10AM -0600, Matthew Wilcox wrote:
> > On Fri, Apr 21, 2006 at 06:43:09PM +0200, Adrian Bunk wrote:
> > > - "depends on SYSFS" instead of the select
> >
> > Why? It's more natural to select it rather than depend on it.
>
> The rule of thumb is that an option is either user visible and should be
> depended on or not user visible and should be select'ed.

What rubbish! Who came up with this rule of thumb?

My rule of thumb is that if an option is infrastructure, then it should
be selected. If it's an addition, then it should be depended.

For example, in SCSI, the transport attributes are individually
selectable, but any driver that wants to use a transport selects it.
It would be foolish to have to answer questions from users who want to
know why they can't select SCSI_AHA152X any more and are told they have
to enable the obscure piece of infrastructure.

An exmaple in the other direction is BRIDGE_NETFILTER. It would be
silly to *not* depend on NETFILTER. The user has said they don't want
to do any kind of network filtering, so would only get annoyed at being
asked about different kinds of network filtering.

This case is clearly infrastructure. The user knows whether or not
they want GFS. If they have to enable sysfs to get GFS, this will only
perplex them.

Obviously, it's not always easy to figure out whether the relationship
between two pieces of code is infrastructure or addition. Sometimes
it's a judgement call.