Re: [PATCH 13/16] GFS2: Makefiles and Kconfig

Adrian Bunk
2006-04-21T16:53:54Z

On Fri, Apr 21, 2006 at 10:49:10AM -0600, Matthew Wilcox wrote:
> On Fri, Apr 21, 2006 at 06:43:09PM +0200, Adrian Bunk wrote:
> > > --- /dev/null
> > > +++ b/fs/gfs2/Kconfig
> > > @@ -0,0 +1,46 @@
> > > +config GFS2_FS
> > > + tristate "GFS2 file system support"
> > > + default m
> > > + depends on EXPERIMENTAL
> > > + select FS_POSIX_ACL
> > > + select SYSFS
> > >...
> >
> > - "depends on SYSFS" instead of the select
>
> Why? It's more natural to select it rather than depend on it.

The rule of thumb is that an option is either user visible and should be
depended on or not user visible and should be select'ed.

Exceptions are possible, but there should be a good reason for them.

It doesn't matter much in this case unless you are really expecting
people to use EMBEDDED=y (IOW: _very_ space limited system) and
GFS2_FS=y/m.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed