Re: [PATCH 13/16] GFS2: Makefiles and Kconfig

Adrian Bunk
2006-04-21T16:43:12Z

On Fri, Apr 21, 2006 at 05:22:38PM +0100, Steven Whitehouse wrote:

>...
> --- a/fs/Kconfig
> +++ b/fs/Kconfig
>...
>
> source "fs/nls/Kconfig"
> +source "fs/dlm/Kconfig"
>...

File doesn't exist

> --- a/fs/Makefile
> +++ b/fs/Makefile
> @@ -48,6 +48,7 @@ obj-$(CONFIG_SYSFS) += sysfs/
> obj-y += devpts/
>
> obj-$(CONFIG_PROFILING) += dcookies.o
> +obj-$(CONFIG_DLM) += dlm/
>...

Directory doesn't exist.

> --- /dev/null
> +++ b/fs/gfs2/Kconfig
> @@ -0,0 +1,46 @@
> +config GFS2_FS
> + tristate "GFS2 file system support"
> + default m
> + depends on EXPERIMENTAL
> + select FS_POSIX_ACL
> + select SYSFS
>...

- tabs <-> spaces (tabs are correct)
- please remove the "default m"
- "depends on SYSFS" instead of the select

> +config GFS2_FS_LOCKING_DLM
> + tristate "GFS2 DLM locking module"
> + depends on GFS2_FS
> + select DLM
>...

DLM in -mm depends on IPV6 || IPV6=n, so if you are select'ing it you
have to add this dependency to GFS2_FS_LOCKING_DLM.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed