Re: [2.6 patch] remove the Root Plug Support sample module

[Greg KH <gregkh@suse.de>]

On Sat, Apr 22, 2006 at 10:57:37AM +0200, Adrian Bunk wrote:
> On Fri, Apr 21, 2006 at 01:29:18PM -0700, Greg KH wrote:
> >...
> > So, I'd like to keep this in the tree, for as long as the LSM interface
> > sticks around, if possible.  It's not hurting anything, and it does work
> > for users, and is a good example starting point for people wanting to
> > use the LSM interface.
> > 
> > Unless there are any known security problems with it?  If so, please let
> > me know.
> 
> Using USB Vendor ID/USB Product ID for identifying an USB device doesn't 
> seem to bring real security since:
> - every other device of the same type works as well
> - using an arbitrary USB device with a manipulated
>   USB Vendor ID/USB Product ID seems quite possible
> 
> It might work as an example, but if people think it would bring them 
> real security that's a dangerous misunderstanding.

What it gives people is a level of security for users that do not have
physical access to the machine.  If you have access to it, yes, of
course you can plug your own device in with the needed ids.

So, I'd still like to keep it around, unless LSM itself goes away.

thanks,

greg k-h