From: Adrian Bunk <bunk@stusta.de>
To: ttb@tentacle.dhs.org, rml@novell.com
Cc: linux-kernel@vger.kernel.org
Subject: [RFC: 2.6 patch] fs/inotify.c: possible cleanups
Date: Sun, 23 Apr 2006 13:47:03 +0200 [thread overview]
Message-ID: <20060423114703.GL5010@stusta.de> (raw)
This patch contains the following possible cleanups:
- make the following needlessly global variables static:
- inotify_max_user_instances
- inotify_max_user_watches
- inotify_max_queued_events
- remove the following unused EXPORT_SYMBOL_GPL's:
- inotify_get_cookie
- inotify_unmount_inodes
- inotify_inode_is_dead
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
fs/inotify.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
--- linux-2.6.17-rc1-mm3-full/fs/inotify.c.old 2006-04-23 12:12:52.000000000 +0200
+++ linux-2.6.17-rc1-mm3-full/fs/inotify.c 2006-04-23 12:18:46.000000000 +0200
@@ -45,9 +45,9 @@
static struct vfsmount *inotify_mnt __read_mostly;
/* these are configurable via /proc/sys/fs/inotify/ */
-int inotify_max_user_instances __read_mostly;
-int inotify_max_user_watches __read_mostly;
-int inotify_max_queued_events __read_mostly;
+static int inotify_max_user_instances __read_mostly;
+static int inotify_max_user_watches __read_mostly;
+static int inotify_max_queued_events __read_mostly;
/*
* Lock ordering:
@@ -627,7 +627,6 @@
{
return atomic_inc_return(&inotify_cookie);
}
-EXPORT_SYMBOL_GPL(inotify_get_cookie);
/**
* inotify_unmount_inodes - an sb is unmounting. handle any watched inodes.
@@ -706,7 +705,6 @@
spin_lock(&inode_lock);
}
}
-EXPORT_SYMBOL_GPL(inotify_unmount_inodes);
/**
* inotify_inode_is_dead - an inode has been deleted, cleanup any watches
@@ -725,7 +723,6 @@
}
mutex_unlock(&inode->inotify_mutex);
}
-EXPORT_SYMBOL_GPL(inotify_inode_is_dead);
/* Device Interface */
next reply other threads:[~2006-04-23 11:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-23 11:47 Adrian Bunk [this message]
[not found] ` <1145828480.32357.0.camel@localhost.localdomain>
2006-04-23 21:41 ` [RFC: 2.6 patch] fs/inotify.c: possible cleanups John McCutchan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060423114703.GL5010@stusta.de \
--to=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@novell.com \
--cc=ttb@tentacle.dhs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox