* [PATCH] Resource leak fix for whiteheat driver
@ 2006-04-23 17:59 Jesper Juhl
0 siblings, 0 replies; only message in thread
From: Jesper Juhl @ 2006-04-23 17:59 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, Stuart MacDonald, linux-usb-devel,
Jesper Juhl
We may return from drivers/usb/serial/whiteheat.c::whiteheat_attach()
without freeing `result' if we leave via the no_firmware: label.
Spotted by the coverity checker as #670
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
drivers/usb/serial/whiteheat.c | 1 +
1 files changed, 1 insertion(+)
--- linux-2.6.17-rc2-git4-orig/drivers/usb/serial/whiteheat.c 2006-03-20 06:53:29.000000000 +0100
+++ linux-2.6.17-rc2-git4/drivers/usb/serial/whiteheat.c 2006-04-23 19:52:27.000000000 +0200
@@ -508,6 +508,7 @@ no_firmware:
err("%s: Unable to retrieve firmware version, try replugging\n", serial->type->description);
err("%s: If the firmware is not running (status led not blinking)\n", serial->type->description);
err("%s: please contact support@connecttech.com\n", serial->type->description);
+ kfree(result);
return -ENODEV;
no_command_private:
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-04-23 17:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-23 17:59 [PATCH] Resource leak fix for whiteheat driver Jesper Juhl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox