From: Andrew Morton <akpm@osdl.org>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: linux-kernel@vger.kernel.org, ericy@cais.com
Subject: Re: [PATCH] binfmt_elf CodingStyle cleanup and remove some pointless casts
Date: Mon, 24 Apr 2006 13:32:34 -0700 [thread overview]
Message-ID: <20060424133234.34a29533.akpm@osdl.org> (raw)
In-Reply-To: <200604241932.49912.jesper.juhl@gmail.com>
Jesper Juhl <jesper.juhl@gmail.com> wrote:
>
> We still need to cast u_platform from pointer to integer or gcc will yell
> at us. But, I don't see why we should first cast it to `unsigned long' and
> then to elf_addr_t, so I removed the `unsigned long' cast.
On 64 bit platforms, these:
some_pointer = (something *)some_u32;
some_u32 = (u32)pointer;
will generate compile warnings concerning the differently-sized quantities
on the lhs and rhs.
The usual way of suppressing this is
some_pointer = (something *)(unsigned long)some_u32;
some_u32 = (unsigned long)pointer;
next prev parent reply other threads:[~2006-04-24 20:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-23 16:58 [PATCH] binfmt_elf CodingStyle cleanup and remove some pointless casts Jesper Juhl
2006-04-23 21:26 ` Andrew Morton
2006-04-24 7:15 ` Jesper Juhl
2006-04-24 17:32 ` Jesper Juhl
2006-04-24 20:32 ` Andrew Morton [this message]
2006-04-24 21:51 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060424133234.34a29533.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ericy@cais.com \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox