From: Stephen Hemminger <shemminger@osdl.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [RFC 2/2] warn on shared edge-triggered irq
Date: Mon, 24 Apr 2006 14:22:52 -0700 [thread overview]
Message-ID: <20060424142252.0a2f235a@localhost.localdomain> (raw)
In-Reply-To: <20060424141926.3872f921@localhost.localdomain>
Put out a warning if setting up shared irq that is edge triggered.
If this happens, interrupts can be lost, but perhaps it is laptop
with unused device, so let it go till later.
--- irq.orig/kernel/irq/manage.c
+++ irq/kernel/irq/manage.c
@@ -234,6 +234,9 @@ int setup_irq(unsigned int irq, struct i
desc->handler->startup(irq);
else
desc->handler->enable(irq);
+ } else if (!(desc->status & IRQ_LEVEL)) {
+ printk(KERN_CRIT "Irq %d (%s) is shared but not level triggered\n",
+ irq, desc->handler->typename);
}
spin_unlock_irqrestore(&desc->lock,flags);
next prev parent reply other threads:[~2006-04-24 21:22 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-24 18:41 better leve triggered IRQ management needed Stephen Hemminger
2006-04-24 18:59 ` linux-os (Dick Johnson)
2006-04-24 19:02 ` Linus Torvalds
2006-04-24 19:08 ` Linus Torvalds
2006-04-24 19:53 ` Arjan van de Ven
2006-04-24 20:16 ` Alan Cox
2006-04-24 20:43 ` Arjan van de Ven
2006-04-24 21:07 ` Linus Torvalds
2006-04-24 21:20 ` Alan Cox
2006-04-24 22:26 ` Linus Torvalds
2006-04-24 21:22 ` [RFC 1/2] irq: record edge-level setting Stephen Hemminger
2006-04-24 21:49 ` Alan Cox
2006-04-24 21:41 ` Stephen Hemminger
2006-04-24 22:34 ` Linus Torvalds
2006-04-24 22:58 ` Stephen Hemminger
[not found] ` <20060424141926.3872f921@localhost.localdomain>
2006-04-24 21:22 ` Stephen Hemminger [this message]
2006-04-25 15:23 ` better leve triggered IRQ management needed Michael Buesch
2006-04-24 19:15 ` Russell King
2006-04-24 20:18 ` Linus Torvalds
2006-04-24 19:25 ` Stephen Hemminger
2006-04-24 19:35 ` linux-os (Dick Johnson)
2006-04-24 20:19 ` Linus Torvalds
2006-04-24 20:50 ` linux-os (Dick Johnson)
2006-04-24 21:09 ` Linus Torvalds
2006-04-29 21:25 ` Alan Cox
2006-04-29 21:58 ` Linus Torvalds
2006-04-30 4:48 ` Neil Brown
2006-04-30 5:19 ` Linus Torvalds
2006-04-30 6:13 ` Neil Brown
2006-04-30 6:59 ` Linus Torvalds
2006-05-02 5:10 ` Neil Brown
2006-05-02 15:05 ` Linus Torvalds
2006-04-30 7:36 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060424142252.0a2f235a@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox