Re: [patch 11/13] s390: instruction processing damage handling.

Heiko Carstens
2006-04-28T08:39:06Z

On Fri, Apr 28, 2006 at 04:33:58AM -0400, Josef Sipek wrote:
> On Mon, Apr 24, 2006 at 05:05:44PM +0200, Martin Schwidefsky wrote:
> > +++ linux-2.6-patched/drivers/s390/s390mach.c 2006-04-24 16:47:28.000000000 +0200
> ...
> > +#define MAX_IPD_TIME (5 * 60 * 100 * 1000) /* 5 minutes */
>
> I'm no s390 expert, but shouldn't the above use something like HZ?

Using HZ here feels just wrong to me. MAX_IPD_TIME has nothing to do with the
timer frequency. In this case it's used to tell if there were 30 machine
checks within the last 5 minutes (in a usec granularity). It's just by
accident that this could be expressed using HZ.
(5 * 60 * USEC_PER_SEC) would probably look better...