Re: [patch 11/13] s390: instruction processing damage handling.

Heiko Carstens
2006-04-28T16:46:08Z

> > >>>>+#define MAX_IPD_TIME (5 * 60 * 100 * 1000) /* 5 minutes */
> > ^^^^^^^^^^^^^^^^^^^^
> > Expression A
> > >>(5 * 60 * USEC_PER_SEC) would probably look better...
> > ^^^^^^^^^^^^^^^^^^^^^^^
> > Expression B
> >
> > I'm no s390 expert either, but just wanted to point out that expression
> > B is 10 times larger than expression A, so something's fishy here.
>
> Indeed, 5*60*100*1000 is wrong. That should be 5*60*1000*1000. This must
> have been the week of stupid bugs.. thanks for spotting this.

*sigh*... stupid me. At least this doesn't break anything and with this
patch it's still better than before.