Re: Compiling C++ modules

Willy Tarreau
2006-04-24T22:30:15Z

On Tue, Apr 25, 2006 at 12:09:01AM +0200, Martin Mares wrote:
> Hello!
>
> > Oh, and yeah, a = b + c *is* more readable than
> >
> > a = malloc(strlen(b) + strlen(c));
> > strcpy(a,b);
> > strcat(a,c);
> >
> > and contains fewer bugs ;)
>
> Actually, it contains at least the bug you have made in your C example,
> that is forgetting that malloc() can fail. So can string addition, if
> allocated dynamically.

And if it does not fail, it may overflow because he forgot one char in
the malloc(). Anyway, I still prefer the C form, at least I know what
it does.

Cheers,
Willy