Re: C++ pushback

Geert Uytterhoeven
2006-04-25T18:02:21Z

On Tue, 25 Apr 2006, J.A. Magallon wrote:
> On Mon, 24 Apr 2006 22:52:12 +0100, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > This is one area of concern. Just as big a problem for the OS case is
> > that the hidden constructors/destructors may fail.
>
> Tell me what is the difference between:
>
>
> sbi = kmalloc(sizeof(*sbi), GFP_KERNEL);
> if (!sbi)
> return -ENOMEM;
> sb->s_fs_info = sbi;
> memset(sbi, 0, sizeof(*sbi));
> sbi->s_mount_opt = 0;
> sbi->s_resuid = EXT3_DEF_RESUID;
> sbi->s_resgid = EXT3_DEF_RESGID;
>
> and
>
> SuperBlock() : s_mount_opt(0), s_resuid(EXT3_DEF_RESUID), s_resgid(EXT3_DEF_RESGID)
> {}
>
> ...
> sbi = new SuperBlock;

You forgot the `nothrow'.

> if (!sbi)
> return -ENOMEM;
>
> apart that you don't get members initalized twice and get a shorter code :).

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds