public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@redhat.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Arjan van de Ven <arjan@infradead.org>,
	Alan Cox <alan@redhat.com>,
	Stephen Hemminger <shemminger@osdl.org>,
	Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Re: better leve triggered IRQ management needed
Date: Mon, 24 Apr 2006 17:20:38 -0400	[thread overview]
Message-ID: <20060424212038.GC4942@devserv.devel.redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0604241354200.3701@g5.osdl.org>

On Mon, Apr 24, 2006 at 02:07:01PM -0700, Linus Torvalds wrote:
> debugging standpoint. So even if it's just that every registered SA_SHIRQ 
> would get a heartbeat at least once every five seconds (and we'd limit it 
> to SA_SHIRQ exactly because a driver that doesn't have that set may get 
> confused if it gets extra interrupts), that might sound totally useless, 
> but it might actually help somebody who otherwise might just make a pretty
> useless "the machine hung" bug-report.

Have to watch enable/disable_irq and the other races here.

> The fake interrupt could even print out a warning if somebody returns 
> SA_HANDLED (since normally there _shouldn't_ have been any work to handle 
> for it), and if that means that for somebody, things go from "the machine 
> hung" to "the machine got very slow, and printed out 'fake interrupt for 
> ide0 returned SA_HANDLED!'", that would potentially be a big debug aid.

There are high rate IRQ sources that would trigger that erratically due to
races but it could be useful in some kind of "linux irqdebug" mode

> We've had our ass saved quite a few times now by the irq storm detector 
> ("irq X: nobody cared" and friends), which has helped debug irqs that 
> haven't been set up properly, that I'm convinced things like this might 
> well make a huge deal.

Yep

Alan
--
  "... and for $64000 question, could you get yourself vaguely familiar with
		the notion of on-topic posting?"
				-- Al Viro


  reply	other threads:[~2006-04-24 21:20 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-24 18:41 better leve triggered IRQ management needed Stephen Hemminger
2006-04-24 18:59 ` linux-os (Dick Johnson)
2006-04-24 19:02 ` Linus Torvalds
2006-04-24 19:08   ` Linus Torvalds
2006-04-24 19:53     ` Arjan van de Ven
2006-04-24 20:16       ` Alan Cox
2006-04-24 20:43         ` Arjan van de Ven
2006-04-24 21:07           ` Linus Torvalds
2006-04-24 21:20             ` Alan Cox [this message]
2006-04-24 22:26               ` Linus Torvalds
2006-04-24 21:22             ` [RFC 1/2] irq: record edge-level setting Stephen Hemminger
2006-04-24 21:49               ` Alan Cox
2006-04-24 21:41                 ` Stephen Hemminger
2006-04-24 22:34                   ` Linus Torvalds
2006-04-24 22:58                     ` Stephen Hemminger
     [not found]             ` <20060424141926.3872f921@localhost.localdomain>
2006-04-24 21:22               ` [RFC 2/2] warn on shared edge-triggered irq Stephen Hemminger
2006-04-25 15:23             ` better leve triggered IRQ management needed Michael Buesch
2006-04-24 19:15   ` Russell King
2006-04-24 20:18     ` Linus Torvalds
2006-04-24 19:25   ` Stephen Hemminger
2006-04-24 19:35   ` linux-os (Dick Johnson)
2006-04-24 20:19     ` Linus Torvalds
2006-04-24 20:50       ` linux-os (Dick Johnson)
2006-04-24 21:09         ` Linus Torvalds
2006-04-29 21:25 ` Alan Cox
2006-04-29 21:58   ` Linus Torvalds
2006-04-30  4:48     ` Neil Brown
2006-04-30  5:19       ` Linus Torvalds
2006-04-30  6:13         ` Neil Brown
2006-04-30  6:59           ` Linus Torvalds
2006-05-02  5:10             ` Neil Brown
2006-05-02 15:05               ` Linus Torvalds
2006-04-30  7:36       ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060424212038.GC4942@devserv.devel.redhat.com \
    --to=alan@redhat.com \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shemminger@osdl.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox