public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Jon Mason <jdmason@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, mulix@mulix.org
Subject: Re: [PATCH] x86-64: trivial gart clean-up
Date: Tue, 25 Apr 2006 00:42:43 +0200	[thread overview]
Message-ID: <200604250042.43910.ak@suse.de> (raw)
In-Reply-To: <20060424225342.GB14575@us.ibm.com>

On Tuesday 25 April 2006 00:53, Jon Mason wrote:
> A trivial change to have gart_unmap_sg call gart_unmap_single directly,
> instead of bouncing through the dma_unmap_single wrapper in
> dma-mapping.h.  This change required moving the gart_unmap_single above
> gart_unmap_sg, and under gart_map_single (which seems a more logical
> place that its current location IMHO).

What advantage does that have? I think I prefer the old code.

-Andi


  reply	other threads:[~2006-04-24 23:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-24 22:53 [PATCH] x86-64: trivial gart clean-up Jon Mason
2006-04-24 22:42 ` Andi Kleen [this message]
2006-04-25  5:26   ` Muli Ben-Yehuda
2006-04-25 13:58     ` Jon Mason
2006-04-26 11:29 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200604250042.43910.ak@suse.de \
    --to=ak@suse.de \
    --cc=jdmason@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mulix@mulix.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox