From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Yu, Luming" <luming.yu@intel.com>
Cc: Andrew Morton <akpm@osdl.org>, "Brown, Len" <len.brown@intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reverse pci config space restore order
Date: Tue, 25 Apr 2006 11:48:00 +0100 [thread overview]
Message-ID: <20060425104800.GA26109@srcf.ucam.org> (raw)
In-Reply-To: <554C5F4C5BA7384EB2B412FD46A3BAD13D48A5@pdsmsx411.ccr.corp.intel.com>
On Tue, Apr 25, 2006 at 02:50:57PM +0800, Yu, Luming wrote:
> - for (i = 0; i < 16; i++)
> + for (i = 15; i >= 0 ; i--)
We certainly need to do /something/ here, but I'm not sure this is it.
Adam Belay has code to limit PCI state restoration to the PCI-specified
registers, with the idea being that individual drivers fix things up
properly. While this has the obvious drawback that almost every PCI
driver in the tree would then need fixing up, it's also probably the
right thing.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2006-04-25 10:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-25 6:50 [PATCH] reverse pci config space restore order Yu, Luming
2006-04-25 10:48 ` Matthew Garrett [this message]
2006-04-25 10:51 ` Arjan van de Ven
2006-04-25 11:01 ` Matthew Garrett
-- strict thread matches above, loose matches on Subject: below --
2006-04-25 18:22 Brown, Len
2006-04-25 23:59 ` abelay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060425104800.GA26109@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luming.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox