Re: 2.6.16.6 ( - 2.6.16.11 ) compile failure on an alpha

Jan-Benedict Glaw
2006-04-25T18:53:43Z

[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]

On Tue, 2006-04-25 11:29:25 +0100, Brian Uhrain <buhrain@rosettastone.com> wrote:
> ---
> arch/alpha/kernel/setup.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> --- linux-2.6.16.11.orig/arch/alpha/kernel/setup.c 2006-04-25 11:21:03.000000000 +0100
> +++ linux-2.6.16.11/arch/alpha/kernel/setup.c 2006-04-25 11:22:56.557266608 +0100
> @@ -483,11 +483,13 @@ register_cpus(void)
> {
> int i;
>
> - for_each_possible_cpu(i) {
> - struct cpu *p = kzalloc(sizeof(*p), GFP_KERNEL);
> - if (!p)
> - return -ENOMEM;
> - register_cpu(p, i, NULL);
> + for (i = 0; i < NR_CPUS; i++) {

Nope. Please implement for_each_possible_cpu(). A patch for that flew
along right today.

> + if (cpu_possible(i)) {
> + struct cpu *p = kzalloc(sizeof(*p), GFP_KERNEL);
> + if (!p)
> + return -ENOMEM;
> + register_cpu(p, i, NULL);
> + }
> }
> return 0;
> }

MfG, JBG

--
Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481 _ O _
"Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg _ _ O
für einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]