Re: 2.6.16.6 ( - 2.6.16.11 ) compile failure on an alpha

Greg KH
2006-04-25T19:45:28Z

On Tue, Apr 25, 2006 at 08:53:40PM +0200, Jan-Benedict Glaw wrote:
> On Tue, 2006-04-25 11:29:25 +0100, Brian Uhrain <buhrain@rosettastone.com> wrote:
> > ---
> > arch/alpha/kernel/setup.c | 12 +++++++-----
> > 1 file changed, 7 insertions(+), 5 deletions(-)
> >
> > --- linux-2.6.16.11.orig/arch/alpha/kernel/setup.c 2006-04-25 11:21:03.000000000 +0100
> > +++ linux-2.6.16.11/arch/alpha/kernel/setup.c 2006-04-25 11:22:56.557266608 +0100
> > @@ -483,11 +483,13 @@ register_cpus(void)
> > {
> > int i;
> >
> > - for_each_possible_cpu(i) {
> > - struct cpu *p = kzalloc(sizeof(*p), GFP_KERNEL);
> > - if (!p)
> > - return -ENOMEM;
> > - register_cpu(p, i, NULL);
> > + for (i = 0; i < NR_CPUS; i++) {
>
> Nope. Please implement for_each_possible_cpu(). A patch for that flew
> along right today.

Yes, that's the proper patch. It's in my queue to add it to the -stable
queue :)

thanks,

greg k-h