* [PATCH] compile error in ieee80211_ioctl.c
@ 2006-04-25 21:04 Alex Davis
2006-04-25 21:11 ` Randy.Dunlap
2006-04-25 21:12 ` John W. Linville
0 siblings, 2 replies; 4+ messages in thread
From: Alex Davis @ 2006-04-25 21:04 UTC (permalink / raw)
To: linville, linux-netdev, linux-kernel
Hello:
I sent this patch earlier and got no response, so I'm sending it again.
I cloned git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-dev.git
last night and got compile errors while compiling net/d80211/ieee80211_ioctl.c
into a module:
CC [M] net/d80211/ieee80211_ioctl.o
net/d80211/ieee80211_ioctl.c:33: error: syntax error before string constant
net/d80211/ieee80211_ioctl.c:33: warning: type defaults to `int' in declaration of `MODULE_PARM'
net/d80211/ieee80211_ioctl.c:33: warning: function declaration isn't a prototype
net/d80211/ieee80211_ioctl.c:33: warning: data definition has no type or storage class
net/d80211/ieee80211_ioctl.c:43: error: syntax error before string constant
net/d80211/ieee80211_ioctl.c:43: warning: type defaults to `int' in declaration of `MODULE_PARM'
net/d80211/ieee80211_ioctl.c:43: warning: function declaration isn't a prototype
net/d80211/ieee80211_ioctl.c:43: warning: data definition has no type or storage class
make[2]: *** [net/d80211/ieee80211_ioctl.o] Error 1
make[1]: *** [net/d80211] Error 2
make: *** [net] Error 2
This patch fixes it.
Signed-off-by: Alex Davis <alex14641@yahoo.com>
diff --git a/net/d80211/ieee80211_ioctl.c b/net/d80211/ieee80211_ioctl.c
index 42a7abe..4949e52 100644
--- a/net/d80211/ieee80211_ioctl.c
+++ b/net/d80211/ieee80211_ioctl.c
@@ -30,7 +30,7 @@ #include "aes_ccm.h"
static int ieee80211_regdom = 0x10; /* FCC */
-MODULE_PARM(ieee80211_regdom, "i");
+module_param(ieee80211_regdom, int, 0x10);
MODULE_PARM_DESC(ieee80211_regdom, "IEEE 802.11 regulatory domain; 64=MKK");
/*
@@ -40,7 +40,7 @@ MODULE_PARM_DESC(ieee80211_regdom, "IEEE
* module.
*/
static int ieee80211_japan_5ghz /* = 0 */;
-MODULE_PARM(ieee80211_japan_5ghz, "i");
+module_param(ieee80211_japan_5ghz, int, 0);
MODULE_PARM_DESC(ieee80211_japan_5ghz, "Vendor-updated firmware for 5 GHz");
I code, therefore I am
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] compile error in ieee80211_ioctl.c
2006-04-25 21:04 [PATCH] compile error in ieee80211_ioctl.c Alex Davis
@ 2006-04-25 21:11 ` Randy.Dunlap
2006-04-25 21:12 ` John W. Linville
1 sibling, 0 replies; 4+ messages in thread
From: Randy.Dunlap @ 2006-04-25 21:11 UTC (permalink / raw)
To: Alex Davis; +Cc: linville, linux-netdev, linux-kernel
On Tue, 25 Apr 2006 14:04:50 -0700 (PDT) Alex Davis wrote:
> Hello:
>
> I sent this patch earlier and got no response, so I'm sending it again.
There was at least one reply, from me.
The third parameter of module_param() is being misused in your patch.
It represents a "permission" value, such as 0, 0444, 0644, etc.
Or you can use existing #defined values for it.
> I cloned git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-dev.git
> last night and got compile errors while compiling net/d80211/ieee80211_ioctl.c
> into a module:
>
> CC [M] net/d80211/ieee80211_ioctl.o
> net/d80211/ieee80211_ioctl.c:33: error: syntax error before string constant
> net/d80211/ieee80211_ioctl.c:33: warning: type defaults to `int' in declaration of `MODULE_PARM'
> net/d80211/ieee80211_ioctl.c:33: warning: function declaration isn't a prototype
> net/d80211/ieee80211_ioctl.c:33: warning: data definition has no type or storage class
> net/d80211/ieee80211_ioctl.c:43: error: syntax error before string constant
> net/d80211/ieee80211_ioctl.c:43: warning: type defaults to `int' in declaration of `MODULE_PARM'
> net/d80211/ieee80211_ioctl.c:43: warning: function declaration isn't a prototype
> net/d80211/ieee80211_ioctl.c:43: warning: data definition has no type or storage class
> make[2]: *** [net/d80211/ieee80211_ioctl.o] Error 1
> make[1]: *** [net/d80211] Error 2
> make: *** [net] Error 2
>
> This patch fixes it.
>
> Signed-off-by: Alex Davis <alex14641@yahoo.com>
>
> diff --git a/net/d80211/ieee80211_ioctl.c b/net/d80211/ieee80211_ioctl.c
> index 42a7abe..4949e52 100644
> --- a/net/d80211/ieee80211_ioctl.c
> +++ b/net/d80211/ieee80211_ioctl.c
> @@ -30,7 +30,7 @@ #include "aes_ccm.h"
>
>
> static int ieee80211_regdom = 0x10; /* FCC */
> -MODULE_PARM(ieee80211_regdom, "i");
> +module_param(ieee80211_regdom, int, 0x10);
> MODULE_PARM_DESC(ieee80211_regdom, "IEEE 802.11 regulatory domain; 64=MKK");
>
> /*
> @@ -40,7 +40,7 @@ MODULE_PARM_DESC(ieee80211_regdom, "IEEE
> * module.
> */
> static int ieee80211_japan_5ghz /* = 0 */;
> -MODULE_PARM(ieee80211_japan_5ghz, "i");
> +module_param(ieee80211_japan_5ghz, int, 0);
> MODULE_PARM_DESC(ieee80211_japan_5ghz, "Vendor-updated firmware for 5 GHz");
---
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] compile error in ieee80211_ioctl.c
2006-04-25 21:04 [PATCH] compile error in ieee80211_ioctl.c Alex Davis
2006-04-25 21:11 ` Randy.Dunlap
@ 2006-04-25 21:12 ` John W. Linville
2006-04-26 16:29 ` Alex Davis
1 sibling, 1 reply; 4+ messages in thread
From: John W. Linville @ 2006-04-25 21:12 UTC (permalink / raw)
To: Alex Davis; +Cc: linux-netdev, linux-kernel
On Tue, Apr 25, 2006 at 02:04:50PM -0700, Alex Davis wrote:
> Hello:
>
> I sent this patch earlier and got no response, so I'm sending it again.
>
>
> I cloned git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-dev.git
> last night and got compile errors while compiling net/d80211/ieee80211_ioctl.c
> into a module:
You may want to wait a little longer before getting huffy...your
original post was on Sunday afternoon (<48 hours ago). You need to
address Randy's concerns as well.
Thanks,
John
--
John W. Linville
linville@tuxdriver.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] compile error in ieee80211_ioctl.c
2006-04-25 21:12 ` John W. Linville
@ 2006-04-26 16:29 ` Alex Davis
0 siblings, 0 replies; 4+ messages in thread
From: Alex Davis @ 2006-04-26 16:29 UTC (permalink / raw)
To: John W. Linville; +Cc: netdev, linux-kernel
--- "John W. Linville" <linville@tuxdriver.com> wrote:
> On Tue, Apr 25, 2006 at 02:04:50PM -0700, Alex Davis wrote:
> > Hello:
> >
> > I sent this patch earlier and got no response, so I'm sending it again.
> >
> >
> > I cloned git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-dev.git
> > last night and got compile errors while compiling net/d80211/ieee80211_ioctl.c
> > into a module:
>
> You need to address Randy's concerns as well.
>
> Thanks,
>
> John
Here is an updated patch which addresses Randy's issues. I'm currently running
this with no problems:
Signed-off-by: Alex Davis <alex14641@yahoo.com>
diff --git a/net/d80211/ieee80211_ioctl.c b/net/d80211/ieee80211_ioctl.c
index 42a7abe..1b14e6c 100644
--- a/net/d80211/ieee80211_ioctl.c
+++ b/net/d80211/ieee80211_ioctl.c
@@ -30,7 +30,7 @@ #include "aes_ccm.h"
static int ieee80211_regdom = 0x10; /* FCC */
-MODULE_PARM(ieee80211_regdom, "i");
+module_param(ieee80211_regdom, int, 0666);
MODULE_PARM_DESC(ieee80211_regdom, "IEEE 802.11 regulatory domain; 64=MKK");
/*
@@ -40,7 +40,7 @@ MODULE_PARM_DESC(ieee80211_regdom, "IEEE
* module.
*/
static int ieee80211_japan_5ghz /* = 0 */;
-MODULE_PARM(ieee80211_japan_5ghz, "i");
+module_param(ieee80211_japan_5ghz, int, 0666);
MODULE_PARM_DESC(ieee80211_japan_5ghz, "Vendor-updated firmware for 5 GHz");
> John W. Linville
> linville@tuxdriver.com
>
I code, therefore I am
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-04-26 16:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-25 21:04 [PATCH] compile error in ieee80211_ioctl.c Alex Davis
2006-04-25 21:11 ` Randy.Dunlap
2006-04-25 21:12 ` John W. Linville
2006-04-26 16:29 ` Alex Davis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox