From: Greg KH <greg@kroah.com>
To: Akinobu Mita <mita@miraclelinux.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org,
Patrick Mochel <mochel@osdl.org>
Subject: Re: [patch 2/2] kref: kref debugging config option
Date: Tue, 25 Apr 2006 17:24:31 -0700 [thread overview]
Message-ID: <20060426002431.GA24343@kroah.com> (raw)
In-Reply-To: <20060425082400.335913000@localhost.localdomain>
On Tue, Apr 25, 2006 at 04:21:39PM +0800, Akinobu Mita wrote:
> - WARN_ON(atomic_read(&kref->refcount) < 1);
> - WARN_ON(release == NULL);
> - WARN_ON(release == (void (*)(struct kref *))kfree);
No, those two last WARN_ON() are not "debugging" checks, they are
"checks for people trying to do bad things with kref code". I always
want them "on", as there should not be any excuse for anyone to do this.
So I don't think this patch is needed at all.
thanks,
greg k-h
prev parent reply other threads:[~2006-04-26 0:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-25 8:21 [patch 0/2] kref debugging (retry) Akinobu Mita
2006-04-25 8:21 ` [patch 1/2] kref: detect kref_put() with unreferenced object Akinobu Mita
2006-04-26 0:26 ` Greg KH
2006-04-26 2:17 ` Akinobu Mita
2006-04-25 8:21 ` [patch 2/2] kref: kref debugging config option Akinobu Mita
2006-04-26 0:24 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060426002431.GA24343@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mita@miraclelinux.com \
--cc=mochel@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox