From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964827AbWDZTCL (ORCPT ); Wed, 26 Apr 2006 15:02:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964832AbWDZTCL (ORCPT ); Wed, 26 Apr 2006 15:02:11 -0400 Received: from ns.virtualhost.dk ([195.184.98.160]:12375 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S964827AbWDZTCK (ORCPT ); Wed, 26 Apr 2006 15:02:10 -0400 Date: Wed, 26 Apr 2006 21:02:46 +0200 From: Jens Axboe To: Christoph Hellwig , Andrew Morton , linux-kernel@vger.kernel.org, npiggin@suse.de, linux-mm@kvack.org Subject: Re: Lockless page cache test results Message-ID: <20060426190245.GN5002@suse.de> References: <20060426135310.GB5083@suse.de> <20060426095511.0cc7a3f9.akpm@osdl.org> <20060426174235.GC5002@suse.de> <20060426111054.2b4f1736.akpm@osdl.org> <20060426185813.GA26680@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060426185813.GA26680@infradead.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 26 2006, Christoph Hellwig wrote: > On Wed, Apr 26, 2006 at 11:10:54AM -0700, Andrew Morton wrote: > > > But boy I wish find_get_pages_contig() was there > > > for that. I think I'd prefer adding that instead of coding that logic in > > > splice, it can get a little tricky. > > > > I guess it'd make sense - we haven't had a need for such a thing before. > > > > umm, something like... > > XFS would have a use for it, too. In fact XFS would prefer a > find_or_create_pages-like thing which is the thing splice wants in > the end aswell. Yes, but preferably without locking the page. So splice really wants a find_get_or_create_pages(). But it wouldn't simplify splice very much in the end, since the worst part of that function is trying to ascertain if the page is good, needs to be read in, truncated, etc. -- Jens Axboe