public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, mchehab@infradead.org
Cc: linux-kernel@vger.kernel.org, v4l-dvb-maintainer@linuxtv.org
Subject: [-mm patch] fix VIDEO_DEV=m, VIDEO_V4L1_COMPAT=y
Date: Thu, 27 Apr 2006 19:57:27 +0200	[thread overview]
Message-ID: <20060427175727.GH3570@stusta.de> (raw)
In-Reply-To: <20060427014141.06b88072.akpm@osdl.org>

On Thu, Apr 27, 2006 at 01:41:41AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.17-rc1-mm3:
>...
> +git-dvb-Kconfig-fix.patch
> +git-dvb-Kconfig-fix-2.patch
> 
>  git-dvb.patch is a bit sick.
>...

These patches are completely sick.

Not every compatibility issue is about 32<->64 Bit...

Below is the patch I sent you after I discovered the bug 
in 2.6.17-rc1-mm3. Is there any reason why you didn't merge my patch?

cu
Adrian


<--  snip  -->


If CONFIG_VIDEO_DEV=m and CONFIG_VIDEO_V4L1_COMPAT=y, v4l1-compat should 
be built as a module (currently, it isn't built at all leading to 
problems with modules using it).

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

This patch was already sent on:
- 18 Apr 2006

--- linux-2.6.17-rc1-mm3-full/drivers/media/video/Makefile.old	2006-04-18 16:52:10.000000000 +0200
+++ linux-2.6.17-rc1-mm3-full/drivers/media/video/Makefile	2006-04-18 16:57:06.000000000 +0200
@@ -11,7 +11,10 @@
 msp3400-objs	:=	msp3400-driver.o msp3400-kthreads.o
 
 obj-$(CONFIG_VIDEO_DEV) += videodev.o v4l2-common.o compat_ioctl32.o
-obj-$(CONFIG_VIDEO_V4L1_COMPAT) += v4l1-compat.o
+
+ifeq ($(CONFIG_VIDEO_V4L1_COMPAT),y)
+  obj-$(CONFIG_VIDEO_DEV) += v4l1-compat.o
+endif
 
 obj-$(CONFIG_VIDEO_BT848) += bt8xx/
 obj-$(CONFIG_VIDEO_BT848) += tvaudio.o tda7432.o tda9875.o ir-kbd-i2c.o


  parent reply	other threads:[~2006-04-27 17:57 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-27  8:41 2.6.17-rc2-mm1 Andrew Morton
2006-04-27 10:16 ` 2.6.17-rc2-mm1 Andi Kleen
2006-04-27 19:19   ` 2.6.17-rc2-mm1 Andrew Morton
2006-04-27 19:26     ` 2.6.17-rc2-mm1 Andi Kleen
2006-04-27 19:44       ` checklist (Re: 2.6.17-rc2-mm1) Randy.Dunlap
2006-04-27 20:11         ` Andrew Morton
2006-04-27 20:17           ` Randy.Dunlap
2006-04-27 20:36           ` Martin Bligh
2006-04-27 19:56             ` Andi Kleen
2006-04-27 21:00               ` Martin Bligh
2006-04-27 20:11                 ` Andi Kleen
2006-04-27 21:22                   ` Martin Bligh
2006-04-28 17:30                     ` Rafał J. Wysocki
2006-04-27 21:00               ` Christoph Hellwig
2006-04-28 14:03             ` Paulo Marques
2006-04-28 15:22               ` Jan Engelhardt
2006-05-01 21:20               ` Valerie Henson
2006-05-01 21:35                 ` Martin Bligh
2006-05-01 23:11                   ` Valerie Henson
2006-04-27 20:52           ` Jan Dittmer
2006-04-27 21:01             ` Randy.Dunlap
2006-04-27 21:41     ` 2.6.17-rc2-mm1 Grant Coady
2006-04-27 21:50       ` 2.6.17-rc2-mm1 Randy.Dunlap
2006-04-27 22:16         ` 2.6.17-rc2-mm1 Andrew Morton
2006-04-27 10:27 ` 2.6.17-rc2-mm1 Michal Piotrowski
2006-04-27 13:07   ` 2.6.17-rc2-mm1 Michal Piotrowski
2006-04-27 15:28     ` 2.6.17-rc2-mm1 Greg KH
2006-04-27 15:32       ` 2.6.17-rc2-mm1 Michal Piotrowski
2006-04-27 20:53         ` 2.6.17-rc2-mm1 Greg KH
2006-04-27 22:09           ` 2.6.17-rc2-mm1 Michal Piotrowski
2006-04-27 15:26   ` 2.6.17-rc2-mm1 Greg KH
2006-04-27 15:43     ` 2.6.17-rc2-mm1 Michal Piotrowski
2006-04-27 15:01 ` 2.6.17-rc2-mm1: ACPI_DOCK=n, HOTPLUG_PCI_ACPI=y compile error Adrian Bunk
2006-04-27 15:47 ` 2.6.17-rc2-mm1 Matthieu CASTET
2006-04-27 18:02   ` 2.6.17-rc2-mm1 Vivek Goyal
2006-04-27 23:24     ` 2.6.17-rc2-mm1 Greg KH
2006-04-28 14:40       ` 2.6.17-rc2-mm1 Vivek Goyal
2006-04-28 16:07     ` 2.6.17-rc2-mm1 matthieu castet
2006-04-28 18:05       ` 2.6.17-rc2-mm1 Vivek Goyal
2006-04-27 17:57 ` Adrian Bunk [this message]
2006-04-27 18:17   ` [-mm patch] fix VIDEO_DEV=m, VIDEO_V4L1_COMPAT=y Andrew Morton
2006-04-27 20:15     ` Mauro Carvalho Chehab
2006-04-27 18:00 ` [-mm patch] fs/nfs/inode.c: make nfs_follow_referral() Adrian Bunk
2006-04-27 18:03 ` [-mm patch] mm/vmscan.c: make shrink_all_zones() static Adrian Bunk
2006-04-27 18:52   ` Rafael J. Wysocki
2006-04-27 20:33 ` [-mm patch] fs/gfs2/: possible cleanups Adrian Bunk
  -- strict thread matches above, loose matches on Subject: below --
2006-04-18 10:14 2.6.17-rc1-mm3 Andrew Morton
2006-04-18 15:07 ` [-mm patch] fix VIDEO_DEV=m, VIDEO_V4L1_COMPAT=y Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060427175727.GH3570@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox