Re: 2.6.17-rc2-mm1

Greg KH
2006-04-27T23:26:14Z

On Thu, Apr 27, 2006 at 02:02:27PM -0400, Vivek Goyal wrote:
> On Thu, Apr 27, 2006 at 05:47:25PM +0200, Matthieu CASTET wrote:
> > Hi Andrew,
> >
> > Le Thu, 27 Apr 2006 01:41:41 -0700, Andrew Morton a ?crit?:
> >
> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17-rc2/2.6.17-rc2-mm1/
> > >
> >
> > 64 bit resources core changes in ioport.h break pnp sysfs interface.
> >
> > A patch like this is needed.
> >
> > Matthieu
> >
> > Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr>
> >
> > --- 1/drivers/pnp/interface.c 2006-01-03 04:21:10.000000000 +0100
> > +++ 2/drivers/pnp/interface.c 2006-04-14 22:54:45.000000000 +0200
> > @@ -264,7 +264,7 @@
> > if (pnp_port_flags(dev, i) & IORESOURCE_DISABLED)
> > pnp_printf(buffer," disabled\n");
> > else
> > - pnp_printf(buffer," 0x%lx-0x%lx\n",
> > + pnp_printf(buffer," 0x%llx-0x%llx\n",
> > pnp_port_start(dev, i),
> > pnp_port_end(dev, i));
>
> I think it would break on ppc64 as u64 is unsigned long. It should be
> explicitly typecasted to unsigned long long. Same is true for all the
> instances.

Does ppc64 use the PnP code?

thanks,

greg k-h