From: Greg KH <greg@kroah.com>
To: Muthu Kumar <muthu.lkml@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: functions named similar (pci_acpi_init)
Date: Thu, 27 Apr 2006 17:00:26 -0700 [thread overview]
Message-ID: <20060428000026.GA29421@kroah.com> (raw)
In-Reply-To: <7da560840604271637n65106962k180234c116614d94@mail.gmail.com>
On Thu, Apr 27, 2006 at 04:37:59PM -0700, Muthu Kumar wrote:
> Hi,
> While looking at something else, got drifted to looking into
> initcall<n>.init. I found two instance of pci_acpi_init() function,
> one in drivers/pci/pci-acpi.c and another in i386/pci/acpi.c.
> I understand this doesnot cause any problem since they are static, but
> someone new looking at the code could fall for it? Is it worth
> changing one of its name or should I just go away :)
If you think changing one of them would help future readers of the code,
sure, feel free to send a patch.
thanks,
greg k-h
next prev parent reply other threads:[~2006-04-28 0:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-27 23:37 functions named similar (pci_acpi_init) Muthu Kumar
2006-04-28 0:00 ` Greg KH [this message]
2006-04-28 0:27 ` Muthu Kumar
2006-04-28 3:23 ` Greg KH
2006-04-28 7:42 ` Muthu Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060428000026.GA29421@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=muthu.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox