Re: [PATCH] PCI: Add pci_assign_resource_fixed -- allow fixed address assignments

[Greg KH <greg@kroah.com>]

On Thu, Apr 27, 2006 at 07:12:14PM -0500, Kumar Gala wrote:
> 
> On Apr 27, 2006, at 5:34 PM, Andrew Morton wrote:
> 
> >Kumar Gala <galak@kernel.crashing.org> wrote:
> >>
> >>On some embedded systems the PCI address for hotplug devices are  
> >>not only
> >>known a priori but are required to be at a given PCI address for  
> >>other
> >>master in the system to be able to access.
> >>
> >>An example of such a system would be an FPGA which is setup from  
> >>user space
> >>after the system has booted.  The FPGA may be access by DSPs in  
> >>the system
> >>and those DSPs expect the FPGA at a fixed PCI address.
> >>
> >>Added pci_assign_resource_fixed() as a way to allow assignment of  
> >>the PCI
> >>devices's BARs at fixed PCI addresses.
> >
> >Is there any sane way in which we can arrange for this function to  
> >not be
> >present in vmlinux's which don't need it?
> >
> >Options would be
> >
> >a) Put it in a .a file.
> >
> >   - messy from a source perspective
> >
> >   - doesn't work if the only reference is from a module
> >
> >   - small gains anyway.
> >
> >b) Use CONFIG_EMBEDDED.
> 
> I'm fine with wrapping it in a CONFIG_EMBEDDED, Greg?

That's fine with me.  Care to send me an updated patch?  I'll drop the
other one then.

thanks,

greg k-h