From: Chandra Seetharaman <sekharan@us.ibm.com>
To: akpm@osdl.org, linux-kernel@vger.kernel.org,
ckrm-tech@lists.sourceforge.net
Cc: Chandra Seetharaman <sekharan@us.ibm.com>
Subject: [PATCH 09/12] Add stats file support to RGCS
Date: Thu, 27 Apr 2006 18:35:00 -0700 [thread overview]
Message-ID: <20060428013500.27212.70582.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20060428013410.27212.45968.sendpatchset@localhost.localdomain>
09/12 - user_interface_stats
Adds attr_store and attr_show support for stats file.
--
Signed-Off-By: Chandra Seetharaman <sekharan@us.ibm.com>
Signed-Off-By: Shailabh Nagar <nagar@watson.ibm.com>
Signed-Off-By: Matt Helsley <matthltc@us.ibm.com>
rgcs.c | 112 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
1 files changed, 110 insertions(+), 2 deletions(-)
Index: linux-2617-rc3/kernel/res_group/rgcs.c
===================================================================
--- linux-2617-rc3.orig/kernel/res_group/rgcs.c 2006-04-27 10:18:44.000000000 -0700
+++ linux-2617-rc3/kernel/res_group/rgcs.c 2006-04-27 10:18:45.000000000 -0700
@@ -20,8 +20,102 @@
#include <linux/parser.h>
#include "local.h"
-static struct configfs_subsystem rgcs_subsys;
-static struct config_item_type rgcs_item_type;
+#define RES_STRING "res"
+
+static ssize_t show_stats(struct resource_group *rgroup, char *buf)
+{
+ int i, j = 0, rc = 0;
+ size_t buf_size = PAGE_SIZE-1; /* allow only PAGE_SIZE # of bytes */
+ struct res_controller *ctlr;
+ struct res_shares *shares;
+
+ for (i = 0; i < MAX_RES_CTLRS; i++, j = 0) {
+ if (buf_size <= 0)
+ break;
+ ctlr = get_controller_by_id(i);
+ if (!ctlr)
+ continue;
+ shares = get_controller_shares(rgroup, ctlr);
+ if (shares && ctlr->show_stats)
+ j = ctlr->show_stats(shares, buf, buf_size);
+ put_controller(ctlr);
+ rc += j;
+ buf += j;
+ buf_size -= j;
+ }
+ if (i < MAX_RES_CTLRS)
+ rc = -ENOSPC;
+ return rc;
+}
+
+enum parse_token_t {
+ parse_res_type, parse_err
+};
+
+static match_table_t parse_tokens = {
+ {parse_res_type, RES_STRING"=%s"},
+ {parse_err, NULL}
+};
+
+static int stats_parse(const char *options,
+ char **resname, char **remaining_line)
+{
+ char *p, *str;
+ int rc = -EINVAL;
+
+ if (!options)
+ return -EINVAL;
+
+ while ((p = strsep((char **)&options, ",")) != NULL) {
+ substring_t args[MAX_OPT_ARGS];
+ int token;
+
+ if (!*p)
+ continue;
+ token = match_token(p, parse_tokens, args);
+ if (token == parse_res_type) {
+ *resname = match_strdup(args);
+ str = p + strlen(p) + 1;
+ *remaining_line = kmalloc(strlen(str) + 1, GFP_KERNEL);
+ if (*remaining_line == NULL) {
+ kfree(*resname);
+ *resname = NULL;
+ rc = -ENOMEM;
+ } else {
+ strcpy(*remaining_line, str);
+ rc = 0;
+ }
+ break;
+ }
+ }
+ return rc;
+}
+
+static int reset_stats(struct resource_group *rgroup, const char *str)
+{
+ int rc;
+ char *resname = NULL, *statstr = NULL;
+ struct res_controller *ctlr;
+ struct res_shares *shares;
+
+ rc = stats_parse(str, &resname, &statstr);
+ if (rc)
+ return rc;
+
+ ctlr = get_controller_by_name(resname);
+ if (!ctlr) {
+ rc = -EINVAL;
+ goto done;
+ }
+ shares = get_controller_shares(rgroup, ctlr);
+ if (shares && ctlr->reset_stats)
+ rc = ctlr->reset_stats(shares, statstr);
+ put_controller(ctlr);
+done:
+ kfree(resname);
+ kfree(statstr);
+ return rc;
+}
struct rgroup_attribute {
struct configfs_attribute configfs_attr;
@@ -29,6 +123,19 @@ struct rgroup_attribute {
int (*store)(struct resource_group *, const char *);
};
+struct rgroup_attribute stats_attr = {
+ .configfs_attr = {
+ .ca_name = "stats",
+ .ca_owner = THIS_MODULE,
+ .ca_mode = S_IRUGO | S_IWUSR
+ },
+ .show = show_stats,
+ .store = reset_stats
+};
+
+static struct configfs_subsystem rgcs_subsys;
+static struct config_item_type rgcs_item_type;
+
struct rgcs_rgroup {
char *name;
struct resource_group *core;
@@ -173,6 +280,7 @@ static struct configfs_group_operations
};
static struct configfs_attribute *rgroup_attrs[] = {
+ &stats_attr.configfs_attr,
NULL
};
--
----------------------------------------------------------------------
Chandra Seetharaman | Be careful what you choose....
- sekharan@us.ibm.com | .......you may get it.
----------------------------------------------------------------------
next prev parent reply other threads:[~2006-04-28 1:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-28 1:34 [PATCH 00/12] Resource Groups... formerly CKRM Chandra Seetharaman
2006-04-28 1:34 ` [PATCH 01/12] Register/Unregister interface for Controllers Chandra Seetharaman
2006-04-28 1:34 ` [PATCH 02/12] Resource group creation/deletion Chandra Seetharaman
2006-04-28 1:34 ` [PATCH 03/12] Share Handling Chandra Seetharaman
2006-04-28 1:34 ` [PATCH 04/12] Add task logic to resource groups Chandra Seetharaman
2006-04-28 1:34 ` [PATCH 05/12] Init and clear resource group info in task Chandra Seetharaman
2006-04-28 1:34 ` [PATCH 06/12] Add proc interface to get resource group info of task Chandra Seetharaman
2006-04-28 1:34 ` [PATCH 07/12] Resource Groups Configfs Subsystem (RGCS) Chandra Seetharaman
2006-04-28 1:34 ` [PATCH 08/12] Add attribute support to RGCS Chandra Seetharaman
2006-04-28 1:35 ` Chandra Seetharaman [this message]
2006-04-28 1:35 ` [PATCH 10/12] Add shares file " Chandra Seetharaman
2006-04-28 1:35 ` [PATCH 11/12] Add members " Chandra Seetharaman
2006-04-28 1:35 ` [PATCH 12/12] Documentation for Resource Groups Chandra Seetharaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060428013500.27212.70582.sendpatchset@localhost.localdomain \
--to=sekharan@us.ibm.com \
--cc=akpm@osdl.org \
--cc=ckrm-tech@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox