public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chandra Seetharaman <sekharan@us.ibm.com>
To: akpm@osdl.org, linux-kernel@vger.kernel.org,
	ckrm-tech@lists.sourceforge.net
Cc: Chandra Seetharaman <sekharan@us.ibm.com>
Subject: [PATCH 11/12] Add members file support to RGCS
Date: Thu, 27 Apr 2006 18:35:11 -0700	[thread overview]
Message-ID: <20060428013511.27212.78544.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20060428013410.27212.45968.sendpatchset@localhost.localdomain>

11/12 - user_interface_members

Adds attr_store and attr_show support for members file.
--

Signed-Off-By: Chandra Seetharaman <sekharan@us.ibm.com>
Signed-Off-By: Shailabh Nagar <nagar@watson.ibm.com>
Signed-Off-By: Matt Helsley <matthltc@us.ibm.com>

 rgcs.c |   49 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 49 insertions(+)

Index: linux-2617-rc3/kernel/res_group/rgcs.c
===================================================================
--- linux-2617-rc3.orig/kernel/res_group/rgcs.c	2006-04-27 10:18:47.000000000 -0700
+++ linux-2617-rc3/kernel/res_group/rgcs.c	2006-04-27 10:18:47.000000000 -0700
@@ -242,6 +242,43 @@ static ssize_t show_shares(struct resour
 	return rc;
 }
 
+/*
+ * Given a buffer with a pid in it, add the task with that pid to the
+ * resource group. Ignores entire buffer after the first pid is parsed.
+ */
+static int add_member(struct resource_group *rgroup, const char *str)
+{
+	pid_t pid;
+
+	pid = (pid_t) simple_strtol(str, NULL, 0);
+	if (pid <= 0)
+		return -EINVAL; /* Not a valid pid */
+	return set_res_group(pid, rgroup);
+}
+
+/*
+ * Lists pids of tasks that belong to the given rgroup.
+ */
+static ssize_t show_members(struct resource_group *rgroup, char *buf)
+{
+	ssize_t i, rc = 0, bufsize = PAGE_SIZE;
+	struct task_struct *tsk;
+
+	spin_lock(&rgroup->group_lock);
+	list_for_each_entry(tsk, &rgroup->task_list, member_list) {
+		if (bufsize <= 0) {
+			rc = -ENOSPC;
+			break;
+		}
+		if (!tsk->pid)	/* Ignore swappers */
+			continue;
+		i = snprintf(buf, bufsize, "%ld\n", (long)tsk->pid);
+		buf += i; rc += i; bufsize -= i;
+	}
+	spin_unlock(&rgroup->group_lock);
+	return rc;
+}
+
 struct rgroup_attribute {
 	struct configfs_attribute configfs_attr;
 	ssize_t (*show)(struct resource_group *, char *);
@@ -268,6 +305,17 @@ struct rgroup_attribute shares_attr = {
 	.store = set_shares
 };
 
+struct rgroup_attribute members_attr = {
+	.configfs_attr = {
+		.ca_name = "members",
+		.ca_owner = THIS_MODULE,
+		.ca_mode = S_IRUGO | S_IWUSR
+	},
+	.show = show_members,
+	.store = add_member
+};
+
+
 static struct configfs_subsystem rgcs_subsys;
 static struct config_item_type rgcs_item_type;
 
@@ -417,6 +465,7 @@ static struct configfs_group_operations 
 static struct configfs_attribute *rgroup_attrs[] = {
 	&stats_attr.configfs_attr,
 	&shares_attr.configfs_attr,
+	&members_attr.configfs_attr,
 	NULL
 };
 

-- 

----------------------------------------------------------------------
    Chandra Seetharaman               | Be careful what you choose....
              - sekharan@us.ibm.com   |      .......you may get it.
----------------------------------------------------------------------

  parent reply	other threads:[~2006-04-28  1:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-28  1:34 [PATCH 00/12] Resource Groups... formerly CKRM Chandra Seetharaman
2006-04-28  1:34 ` [PATCH 01/12] Register/Unregister interface for Controllers Chandra Seetharaman
2006-04-28  1:34 ` [PATCH 02/12] Resource group creation/deletion Chandra Seetharaman
2006-04-28  1:34 ` [PATCH 03/12] Share Handling Chandra Seetharaman
2006-04-28  1:34 ` [PATCH 04/12] Add task logic to resource groups Chandra Seetharaman
2006-04-28  1:34 ` [PATCH 05/12] Init and clear resource group info in task Chandra Seetharaman
2006-04-28  1:34 ` [PATCH 06/12] Add proc interface to get resource group info of task Chandra Seetharaman
2006-04-28  1:34 ` [PATCH 07/12] Resource Groups Configfs Subsystem (RGCS) Chandra Seetharaman
2006-04-28  1:34 ` [PATCH 08/12] Add attribute support to RGCS Chandra Seetharaman
2006-04-28  1:35 ` [PATCH 09/12] Add stats file " Chandra Seetharaman
2006-04-28  1:35 ` [PATCH 10/12] Add shares " Chandra Seetharaman
2006-04-28  1:35 ` Chandra Seetharaman [this message]
2006-04-28  1:35 ` [PATCH 12/12] Documentation for Resource Groups Chandra Seetharaman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060428013511.27212.78544.sendpatchset@localhost.localdomain \
    --to=sekharan@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=ckrm-tech@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox