From: Andrew Morton <akpm@osdl.org>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org, Ian Kent <raven@themaw.net>,
Matt Mackall <mpm@selenic.com>, Pavel Machek <pavel@ucw.cz>
Subject: Re: initcall warnings in 2.6.17
Date: Fri, 28 Apr 2006 10:54:03 -0700 [thread overview]
Message-ID: <20060428105403.250eb2d6.akpm@osdl.org> (raw)
In-Reply-To: <200604281406.34217.ak@suse.de>
Andi Kleen <ak@suse.de> wrote:
>
> I still get
>
> initcall at 0xffffffff807414c2: pci_iommu_init+0x0/0x501(): returned with error code -1
Should be returning -ENODEV.
> initcall at 0xffffffff80748b4d: init_autofs4_fs+0x0/0xc(): returned with error code -16
hm. Why'd that happen?
> initcall at 0xffffffff803c7d5c: init_netconsole+0x0/0x6b(): returned with error code -22
Yeah. I think netconsole is just being wrong here. If it wasn't enabled
there's no error.
> initcall at 0xffffffff80249307: software_resume+0x0/0xcf(): returned with error code -2
Similarly, there's no resume file configured so should we really consider
this an error?
> I'm not sure it was that good an idea to enable this warning by default in 2.6.17.
> It will be still in the release and probably generate some user queries.
>
> Might be better to disable it for 2.6.17 again and only reenable for 2.6.18 after
> some auditing?
>
Yes, I'm inclined to agree. It's finding some real but very minor
problems. Probably too minor to be scaring users. I'll cook up a patch to
move it under `initcall_debug'.
next prev parent reply other threads:[~2006-04-28 17:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-28 12:06 initcall warnings in 2.6.17 Andi Kleen
2006-04-28 17:54 ` Andrew Morton [this message]
2006-04-28 18:14 ` Pavel Machek
2006-05-02 11:28 ` Pavel Machek
2006-05-02 22:44 ` [PATCH] clean-up initcall warning for netconsole Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060428105403.250eb2d6.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=pavel@ucw.cz \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox