initcall warnings in 2.6.17

initcall warnings in 2.6.17

[Andi Kleen]

I still get

initcall at 0xffffffff807414c2: pci_iommu_init+0x0/0x501(): returned with error code -1
initcall at 0xffffffff80748b4d: init_autofs4_fs+0x0/0xc(): returned with error code -16
initcall at 0xffffffff803c7d5c: init_netconsole+0x0/0x6b(): returned with error code -22
initcall at 0xffffffff80249307: software_resume+0x0/0xcf(): returned with error code -2

I'm not sure it was that good an idea to enable this warning by default in 2.6.17.
It will be still in the release and probably generate some user queries.

Might be better to disable it for 2.6.17 again and only reenable for 2.6.18 after
some auditing?

-Andi

Re: initcall warnings in 2.6.17

[Andrew Morton]

Andi Kleen <ak@suse.de> wrote:
>
> I still get
> 
> initcall at 0xffffffff807414c2: pci_iommu_init+0x0/0x501(): returned with error code -1

Should be returning -ENODEV.

> initcall at 0xffffffff80748b4d: init_autofs4_fs+0x0/0xc(): returned with error code -16

hm.  Why'd that happen?

> initcall at 0xffffffff803c7d5c: init_netconsole+0x0/0x6b(): returned with error code -22

Yeah.  I think netconsole is just being wrong here.  If it wasn't enabled
there's no error.

> initcall at 0xffffffff80249307: software_resume+0x0/0xcf(): returned with error code -2

Similarly, there's no resume file configured so should we really consider
this an error?


> I'm not sure it was that good an idea to enable this warning by default in 2.6.17.
> It will be still in the release and probably generate some user queries.
> 
> Might be better to disable it for 2.6.17 again and only reenable for 2.6.18 after
> some auditing?
> 

Yes, I'm inclined to agree.  It's finding some real but very minor
problems.  Probably too minor to be scaring users.  I'll cook up a patch to
move it under `initcall_debug'.

Re: initcall warnings in 2.6.17

[Pavel Machek]

On Pá 28-04-06 10:54:03, Andrew Morton wrote:
> Andi Kleen <ak@suse.de> wrote:
> >
> > I still get
> > 
> > initcall at 0xffffffff807414c2: pci_iommu_init+0x0/0x501(): returned with error code -1
> 
> Should be returning -ENODEV.
> 
> > initcall at 0xffffffff80748b4d: init_autofs4_fs+0x0/0xc(): returned with error code -16
> 
> hm.  Why'd that happen?
> 
> > initcall at 0xffffffff803c7d5c: init_netconsole+0x0/0x6b(): returned with error code -22
> 
> Yeah.  I think netconsole is just being wrong here.  If it wasn't enabled
> there's no error.
> 
> > initcall at 0xffffffff80249307: software_resume+0x0/0xcf(): returned with error code -2
> 
> Similarly, there's no resume file configured so should we really consider
> this an error?

That one is easier to solve. But "configured but image not present"
will also produce warning I guess. If I return -ENODEV, will it keep
debugging system quiet?
								Pavel
-- 
Thanks for all the (sleeping) penguins.

Re: initcall warnings in 2.6.17

[Pavel Machek]

Hi!

This should fix

> > initcall at 0xffffffff80249307: software_resume+0x0/0xcf(): returned with error code -2

warning.

Signed-off-by: Pavel Machek <pavel@suse.cz>

diff --git a/kernel/power/disk.c b/kernel/power/disk.c
index 81d4d98..1019aca 100644
--- a/kernel/power/disk.c
+++ b/kernel/power/disk.c
@@ -168,7 +168,7 @@ static int software_resume(void)
 	if (!swsusp_resume_device) {
 		if (!strlen(resume_file)) {
 			up(&pm_sem);
-			return -ENOENT;
+			return 0;
 		}
 		swsusp_resume_device = name_to_dev_t(resume_file);
 		pr_debug("swsusp: Resume From Partition %s\n", resume_file);

-- 
Thanks for all the (sleeping) penguins.

[PATCH] clean-up initcall warning for netconsole

[Matt Mackall]

On Fri, Apr 28, 2006 at 10:54:03AM -0700, Andrew Morton wrote:
> Yeah.  I think netconsole is just being wrong here.  If it wasn't enabled
> there's no error.

Here's a fix:

Index: 2.6/drivers/net/netconsole.c
===================================================================
--- 2.6.orig/drivers/net/netconsole.c	2006-05-02 17:28:43.000000000 -0500
+++ 2.6/drivers/net/netconsole.c	2006-05-02 17:43:37.000000000 -0500
@@ -107,7 +107,7 @@ static int init_netconsole(void)
 
 	if(!configured) {
 		printk("netconsole: not configured, aborting\n");
-		return -EINVAL;
+		return 0;
 	}
 
 	if(netpoll_setup(&np))


-- 
Mathematics is the supreme nostalgia of our time.