From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Paulo Marques <pmarques@grupopie.com>,
Josef Sipek <jsipek@fsl.cs.sunysb.edu>,
linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [patch 11/13] s390: instruction processing damage handling.
Date: Fri, 28 Apr 2006 18:46:01 +0200 [thread overview]
Message-ID: <20060428164601.GA10420@osiris.ibm.com> (raw)
In-Reply-To: <1146236009.26676.18.camel@localhost>
> > >>>>+#define MAX_IPD_TIME (5 * 60 * 100 * 1000) /* 5 minutes */
> > ^^^^^^^^^^^^^^^^^^^^
> > Expression A
> > >>(5 * 60 * USEC_PER_SEC) would probably look better...
> > ^^^^^^^^^^^^^^^^^^^^^^^
> > Expression B
> >
> > I'm no s390 expert either, but just wanted to point out that expression
> > B is 10 times larger than expression A, so something's fishy here.
>
> Indeed, 5*60*100*1000 is wrong. That should be 5*60*1000*1000. This must
> have been the week of stupid bugs.. thanks for spotting this.
*sigh*... stupid me. At least this doesn't break anything and with this
patch it's still better than before.
prev parent reply other threads:[~2006-04-28 16:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-24 15:05 [patch 11/13] s390: instruction processing damage handling Martin Schwidefsky
2006-04-24 23:58 ` Andrew Morton
2006-04-25 20:14 ` Arnd Bergmann
2006-04-28 7:33 ` Josef Sipek
2006-04-28 8:39 ` Heiko Carstens
2006-04-28 9:24 ` Martin Schwidefsky
2006-04-28 13:43 ` Paulo Marques
2006-04-28 14:53 ` Martin Schwidefsky
2006-04-28 16:46 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060428164601.GA10420@osiris.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=akpm@osdl.org \
--cc=jsipek@fsl.cs.sunysb.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=pmarques@grupopie.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox