From: Andi Kleen <ak@suse.de>
To: minyard@acm.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86_64: add nmi_exit to die_nmi
Date: Sat, 29 Apr 2006 12:58:55 +0200 [thread overview]
Message-ID: <200604291258.55430.ak@suse.de> (raw)
In-Reply-To: <20060427175551.GA22941@i2.minyard.local>
On Thursday 27 April 2006 19:55, Corey Minyard wrote:
> Playing with NMI watchdog on x86_64, I discovered that it didn't
> do what I expected. It always panic-ed, even when it didn't
> happen from interrupt context.
Hmm, I don't think that's true. Or at least it worked at some point.
Ok maybe something regressed.
> This patch solves that
> problem for me. Also, in this case, do_exit() will be called
> with interrupts disabled, I believe. Would it be wise to also
> call local_irq_enable() after nmi_exit()?
Probably yes. I added that with the the patch.
Thanks,
-Andi
prev parent reply other threads:[~2006-04-29 11:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-27 17:55 [PATCH] x86_64: add nmi_exit to die_nmi Corey Minyard
2006-04-29 10:58 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604291258.55430.ak@suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox