From: Pavel Machek <pavel@ucw.cz>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
John Lenz <lenz@cs.wisc.edu>,
Richard Purdie <rpurdie@openedhand.com>
Subject: Re: led_class: storing a value can act but return -EINVAL
Date: Sun, 30 Apr 2006 10:02:43 +0000 [thread overview]
Message-ID: <20060430100243.GB4452@ucw.cz> (raw)
In-Reply-To: <1146310432.5019.45.camel@localhost>
Hi!
> When I store something into the brightness sysfs attribute of an LED, it
> will accept the value but return -EINVAL:
>
> johannes:/sys/class/leds/pmu-front-led# echo 255 > brightness
> bash: echo: write error: Invalid argument
>
> (yet the LED turns on)
>
> This happens because the store callback doesn't consume all the input.
Well, I'd argue current behaviour is okay... can you strace it? It
should accept the number (return 3) then return -EINVAL.
> There are two possible ways to handle this:
> a) accept anything that begins with a valid number.
> b) reject anything that isn't *only* a number
c) accept anything that is number, ignore newlines.
a) is just way too ugly...
Pavel
--
Thanks, Sharp!
next prev parent reply other threads:[~2006-04-30 10:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-29 11:33 led_class: storing a value can act but return -EINVAL Johannes Berg
2006-04-30 10:02 ` Pavel Machek [this message]
2006-04-30 11:01 ` Johannes Berg
2006-04-30 11:57 ` Richard Purdie
2006-04-30 12:05 ` Johannes Berg
2006-04-30 12:10 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060430100243.GB4452@ucw.cz \
--to=pavel@ucw.cz \
--cc=johannes@sipsolutions.net \
--cc=lenz@cs.wisc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox