* [RFC: 2.6 patch] fs/sync.c: make do_sync_file_range() static
@ 2006-04-23 21:22 Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2006-04-23 21:22 UTC (permalink / raw)
To: linux-kernel
This patch makes the needlessly global do_sync_file_range() static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
fs/sync.c | 8 +++++---
include/linux/fs.h | 2 --
2 files changed, 5 insertions(+), 5 deletions(-)
--- linux-2.6.17-rc1-mm3-full/include/linux/fs.h.old 2006-04-23 15:54:22.000000000 +0200
+++ linux-2.6.17-rc1-mm3-full/include/linux/fs.h 2006-04-23 15:54:38.000000000 +0200
@@ -762,8 +762,6 @@
#define SYNC_FILE_RANGE_WAIT_BEFORE 1
#define SYNC_FILE_RANGE_WRITE 2
#define SYNC_FILE_RANGE_WAIT_AFTER 4
-extern int do_sync_file_range(struct file *file, loff_t offset, loff_t endbyte,
- unsigned int flags);
/* fs/locks.c */
extern void locks_init_lock(struct file_lock *);
--- linux-2.6.17-rc1-mm3-full/fs/sync.c.old 2006-04-23 15:53:30.000000000 +0200
+++ linux-2.6.17-rc1-mm3-full/fs/sync.c 2006-04-23 15:54:15.000000000 +0200
@@ -14,6 +14,9 @@
#define VALID_FLAGS (SYNC_FILE_RANGE_WAIT_BEFORE|SYNC_FILE_RANGE_WRITE| \
SYNC_FILE_RANGE_WAIT_AFTER)
+static int do_sync_file_range(struct file *file, loff_t offset, loff_t endbyte,
+ unsigned int flags);
+
/*
* sys_sync_file_range() permits finely controlled syncing over a segment of
* a file in the range offset .. (offset+nbytes-1) inclusive. If nbytes is
@@ -125,8 +128,8 @@
/*
* `endbyte' is inclusive
*/
-int do_sync_file_range(struct file *file, loff_t offset, loff_t endbyte,
- unsigned int flags)
+static int do_sync_file_range(struct file *file, loff_t offset, loff_t endbyte,
+ unsigned int flags)
{
int ret;
struct address_space *mapping;
@@ -161,4 +164,3 @@
out:
return ret;
}
-EXPORT_SYMBOL_GPL(do_sync_file_range);
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RFC: 2.6 patch] fs/sync.c: make do_sync_file_range() static
@ 2006-05-01 7:11 Adrian Bunk
2006-05-01 7:18 ` Neil Brown
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2006-05-01 7:11 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
This patch makes the needlessly global do_sync_file_range() static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 23 Apr 2006
fs/sync.c | 8 +++++---
include/linux/fs.h | 2 --
2 files changed, 5 insertions(+), 5 deletions(-)
--- linux-2.6.17-rc1-mm3-full/include/linux/fs.h.old 2006-04-23 15:54:22.000000000 +0200
+++ linux-2.6.17-rc1-mm3-full/include/linux/fs.h 2006-04-23 15:54:38.000000000 +0200
@@ -762,8 +762,6 @@
#define SYNC_FILE_RANGE_WAIT_BEFORE 1
#define SYNC_FILE_RANGE_WRITE 2
#define SYNC_FILE_RANGE_WAIT_AFTER 4
-extern int do_sync_file_range(struct file *file, loff_t offset, loff_t endbyte,
- unsigned int flags);
/* fs/locks.c */
extern void locks_init_lock(struct file_lock *);
--- linux-2.6.17-rc1-mm3-full/fs/sync.c.old 2006-04-23 15:53:30.000000000 +0200
+++ linux-2.6.17-rc1-mm3-full/fs/sync.c 2006-04-23 15:54:15.000000000 +0200
@@ -14,6 +14,9 @@
#define VALID_FLAGS (SYNC_FILE_RANGE_WAIT_BEFORE|SYNC_FILE_RANGE_WRITE| \
SYNC_FILE_RANGE_WAIT_AFTER)
+static int do_sync_file_range(struct file *file, loff_t offset, loff_t endbyte,
+ unsigned int flags);
+
/*
* sys_sync_file_range() permits finely controlled syncing over a segment of
* a file in the range offset .. (offset+nbytes-1) inclusive. If nbytes is
@@ -125,8 +128,8 @@
/*
* `endbyte' is inclusive
*/
-int do_sync_file_range(struct file *file, loff_t offset, loff_t endbyte,
- unsigned int flags)
+static int do_sync_file_range(struct file *file, loff_t offset, loff_t endbyte,
+ unsigned int flags)
{
int ret;
struct address_space *mapping;
@@ -161,4 +164,3 @@
out:
return ret;
}
-EXPORT_SYMBOL_GPL(do_sync_file_range);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC: 2.6 patch] fs/sync.c: make do_sync_file_range() static
2006-05-01 7:11 [RFC: 2.6 patch] fs/sync.c: make do_sync_file_range() static Adrian Bunk
@ 2006-05-01 7:18 ` Neil Brown
0 siblings, 0 replies; 3+ messages in thread
From: Neil Brown @ 2006-05-01 7:18 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel
On Monday May 1, bunk@stusta.de wrote:
> This patch makes the needlessly global do_sync_file_range() static.
I'm planning to use that in nfsd. Just haven't got there yet.
NeilBrown
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-05-01 7:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-01 7:11 [RFC: 2.6 patch] fs/sync.c: make do_sync_file_range() static Adrian Bunk
2006-05-01 7:18 ` Neil Brown
-- strict thread matches above, loose matches on Subject: below --
2006-04-23 21:22 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox