From: Greg KH <greg@kroah.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
tiwai@suse.de, henne@nachtwindheim.de
Subject: Re: [ALSA] add __devinitdata to all pci_device_id
Date: Mon, 1 May 2006 09:54:43 -0700 [thread overview]
Message-ID: <20060501165443.GA9441@kroah.com> (raw)
In-Reply-To: <1146502164.20760.53.camel@laptopd505.fenrus.org>
On Mon, May 01, 2006 at 06:49:24PM +0200, Arjan van de Ven wrote:
> On Mon, 2006-05-01 at 15:11 +0000, Linux Kernel Mailing List wrote:
> > commit 396c9b928d5c24775846a161a8191dcc1ea4971f
> > tree 447f4b28c2dd8e0026b96025fb94dbc654d6cade
> > parent 71b2ccc3a2fd6c27e3cd9b4239670005978e94ce
> > author Henrik Kretzschmar <henne@nachtwindheim.de> Mon, 24 Apr 2006 15:59:04 +0200
> > committer Jaroslav Kysela <perex@suse.cz> Thu, 27 Apr 2006 21:10:34 +0200
> >
> > [ALSA] add __devinitdata to all pci_device_id
>
>
> are you really really sure you want to do this?
> These structures are exported via sysfs for example, I would think this
> is quite the wrong thing to make go away silently...
I asked Henrik to not do this, but oh well...
No, if they are marked __devinit, and CONFIG_HOTPLUG is enabled, then
the sysfs stuff is enabled. And since CONFIG_HOTPLUG is pretty much
always enabled these days, the savings of this kind of patch is
non-existant...
greg k-h
next prev parent reply other threads:[~2006-05-01 16:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200605011511.k41FBUcu025025@hera.kernel.org>
2006-05-01 16:49 ` [ALSA] add __devinitdata to all pci_device_id Arjan van de Ven
2006-05-01 16:54 ` Greg KH [this message]
2006-05-02 9:48 ` Takashi Iwai
2006-05-02 22:48 ` Greg KH
2006-05-01 20:47 Henne
2006-05-02 15:36 ` Henne
2006-05-11 0:12 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060501165443.GA9441@kroah.com \
--to=greg@kroah.com \
--cc=arjan@infradead.org \
--cc=henne@nachtwindheim.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox